Differential D1114

Simplify archive listing
AbandonedPublic
Actions

Authored by elvisangelaccio on Mar 10 2016, 11:17 PM.

Details

Reviewers
rthomsen
Summary

If we list the archive in the Archive constructor, we can drop the m_hasBeenListed flag
and also the listIfNotListed() function.
This way we can also mark isPasswordProtected() as const.

Diff Detail

Repository
R36 Ark
Branch
nolistIfNotListed
Lint
No Linters Available
Unit
No Unit Test Coverage
elvisangelaccio updated this revision to Diff 2688.Mar 10 2016, 11:17 PM
elvisangelaccio retitled this revision from to Simplify archive listing.
elvisangelaccio added a reviewer: rthomsen.
elvisangelaccio updated this object.
Restricted Application added a project: Ark. · View Herald TranscriptMar 10 2016, 11:17 PM
Restricted Application added a subscriber: kde-utils-devel. · View Herald Transcript
elvisangelaccio planned changes to this revision.Mar 10 2016, 11:41 PM

After a 2nd thougth, this is very bad idea. If the archive is huge, we actually end up listing it twice: once in the constructor and once in ArchiveModel::setArchive().

I'll have to think to another solution...

elvisangelaccio abandoned this revision.Mar 11 2016, 10:32 AM

I'm discarding this patch. I discovered another (related) issue with the properties dialog, which I will address in another diff.

Revision Contents
Changeset List

Diff 2688

View Options

kerfuffle/archive_kerfuffle.h

Loading...
View Options

kerfuffle/archive_kerfuffle.cpp

Loading...