This differential merges the play and pause button
Details
- Reviewers
sandroandrade - Maniphest Tasks
- T1793: Merge 'Play' and 'Pause' button in MidiPlayer
- Commits
- R163:cdc66fce54c8: Merge the play and pause button
Instead of having two multimedia buttons, we can have the functionality with only one button with two states.
One state for play and other for pause.
The state can change if one of the three functions are called
void MidiSequencer::play() void MidiSequencer::pause() void MidiSequencer::stop()
Hence whenever they are called, a signal is sent to slot in MidiPlayer.qml.
Diff Detail
- Repository
- R163 Minuet
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Hi,
Please make the suggested changes and submit a new patch in this same Differential D1106.
Also, please rebase your changes against current master state, since new commits have arrived since then.
Thanks,
src/midisequencer.cpp | ||
---|---|---|
183 | Please emit stateChanged(MidiSequencer::StoppedState) here and act accordingly in QML files. | |
194 | Please emit stateChanged(MidiSequencer::PlayingState) here. | |
205 | Please emit stateChanged(MidiSequencer::PausedState) here. | |
214 | Please emit stateChanged(MidiSequencer::StoppedState) here. | |
src/midisequencer.h | ||
67 | Please name this method 'stateChanged'. |
Should the states in State enum be in all caps?
like STOPPED_STATE instead of StoppedState?