Differential D1103

[Folder View] Add "Icon Size" to "Icons" context menu
ClosedPublic
Actions

Authored by broulik on Mar 10 2016, 11:05 AM.

Details

Reviewers
hein
Group Reviewers
Plasma
Commits
R119:3bf5a5a1c592: [Folder View] Add "Icon Size" to "Icons" context menu
Summary

As requested by VDG

BUG: 360351
FIXED-IN: 5.7.0

Test Plan

Choosing a different size in the context menu changes the icon size and reflects that in the config dialog
Choosing a different size in the config dialog updates the context menu action

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik updated this revision to Diff 2659.Mar 10 2016, 11:05 AM
broulik retitled this revision from to [Folder View] Add "Icon Size" to "Icons" context menu.
broulik updated this object.
broulik edited the test plan for this revision. (Show Details)
broulik added reviewers: Plasma, hein.
broulik set the repository for this revision to R119 Plasma Desktop.
broulik added a project: Plasma.
Restricted Application added a subscriber: plasma-devel. · View Herald TranscriptMar 10 2016, 11:05 AM
hein accepted this revision.Mar 10 2016, 11:13 AM
hein edited edge metadata.

This looks fine, but I'm not sure we want to expose awkward icon size names like "Small Medium" to users. But that's a broader point that has to be addressed separately.

This revision is now accepted and ready to land.Mar 10 2016, 11:13 AM
Closed by commit R119:3bf5a5a1c592: [Folder View] Add "Icon Size" to "Icons" context menu (authored by broulik). · Explain WhyMar 10 2016, 11:29 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2661

View Options

containments/desktop/package/contents/ui/FolderViewLayer.qml

Loading...
View Options

containments/desktop/plugins/folder/viewpropertiesmenu.h

Loading...
View Options

containments/desktop/plugins/folder/viewpropertiesmenu.cpp

Loading...