Introduce KTransactionFilter
ClosedPublic
Actions

Authored by wojnilowicz on Mar 4 2018, 10:14 AM.

Details

Reviewers

Commits

R261:afcdb30a02ca: Introduce KTransactionFilter

Summary

Purpose of this patch is to make KReportConfigurationFilterDlg independent from KFindTransactionDlg. It's done by introducing KTransactionFilter which doesn't depend on KMyMoneyRegister and is a kind of frontend for setting MyMoneyTransactionFilter.
This approach will allow us to make plugin out of KReportsView and it makes interface tidier as presented on the image below.

Diff Detail

Repository

R261 KMyMoney

Lint

Lint Skipped

Unit

Unit Tests Skipped

wojnilowicz requested review of this revision.Mar 4 2018, 10:14 AM

wojnilowicz created this revision.

tbaumgart added inline comments.Mar 7 2018, 4:45 PM

kmymoney/widgets/ktransactionfilter.cpp
111	QStringLiteral(", ")
123	same here
129	and here, and a few more I don't mark

wojnilowicz updated this revision to Diff 28969.Mar 7 2018, 6:21 PM

Looks good to me

kmymoney/widgets/ktransactionfilter.cpp
106	Is there a reason why you don't make this a const QString?

This revision is now accepted and ready to land.Mar 8 2018, 6:17 PM

wojnilowicz closed this revision.Mar 9 2018, 6:39 PM

Revision Contents
Changeset List

		Path
M		kmymoney/dialogs/CMakeLists.txt (1 line)
M		kmymoney/dialogs/kfindtransactiondlg.h (16 lines)
M		kmymoney/dialogs/kfindtransactiondlg.cpp (206 lines)
M		kmymoney/dialogs/kfindtransactiondlg.ui (880 lines)
M		kmymoney/dialogs/kfindtransactiondlg_p.h (440 lines)
M		kmymoney/dialogs/kreportconfigurationfilterdlg.h (12 lines)
M		kmymoney/dialogs/kreportconfigurationfilterdlg.cpp (257 lines)
A	M	kmymoney/dialogs/kreportconfigurationfilterdlg.ui (89 lines)
M		kmymoney/widgets/CMakeLists.txt (8 lines)
M		kmymoney/widgets/daterangedlg.h (4 lines)
M		kmymoney/widgets/kmymoneyaccountselector.h (6 lines)
A	M	kmymoney/widgets/ktransactionfilter.h (100 lines)
A	M	kmymoney/widgets/ktransactionfilter.cpp (549 lines)
A	M	kmymoney/widgets/ktransactionfilter.ui (868 lines)
A	M	kmymoney/widgets/ktransactionfilter_p.h (409 lines)

Diff	ID	Description	Created	Lint	Unit
Base		Base
Diff 1	28570		Mar 4 2018, 10:12 AM	★	★
Diff 2	28969		Mar 7 2018, 6:20 PM	★	★

Introduce KTransactionFilterClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 28969

kmymoney/dialogs/CMakeLists.txt

kmymoney/dialogs/kfindtransactiondlg.h

kmymoney/dialogs/kfindtransactiondlg.cpp

kmymoney/dialogs/kfindtransactiondlg.ui

kmymoney/dialogs/kfindtransactiondlg_p.h

kmymoney/dialogs/kreportconfigurationfilterdlg.h

kmymoney/dialogs/kreportconfigurationfilterdlg.cpp

kmymoney/dialogs/kreportconfigurationfilterdlg.ui

kmymoney/widgets/CMakeLists.txt

kmymoney/widgets/daterangedlg.h

kmymoney/widgets/kmymoneyaccountselector.h

kmymoney/widgets/ktransactionfilter.h

kmymoney/widgets/ktransactionfilter.cpp

kmymoney/widgets/ktransactionfilter.ui

kmymoney/widgets/ktransactionfilter_p.h

Introduce KTransactionFilter
ClosedPublic
Actions

Revision Contents
Changeset List