Differential D10981

Correctly handle changing canPlay, canPause, canGoNext and canGoPrevious
ClosedPublic
Actions

Authored by nicolasfella on Mar 2 2018, 10:37 PM.

Details

Reviewers
mtijink
Group Reviewers
KDE Connect
Commits
R225:959c7c722033: Correctly handle changing canPlay, canPause, canGoNext and canGoPrevious
Summary

Gwenview is adding MPRIS support in D10972. I tested it and noticed that it was quite buggy. Turns out,
Gwenviews implementation is (almost) fine, the problem was on our side. Unlike pure music players like
Spotify Gwenview changes canPlay, canPause, canGoNext and canGoPrevious when needed, but those updates
didn't reach our UI. The packages containing those updates were not parsed because they didn't contain
several fields.

Test Plan

Controlling Spotify and Gwenview (patched to support playPause) works fine now.

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
nicolasfella requested review of this revision.Mar 2 2018, 10:37 PM
nicolasfella created this revision.
mtijink accepted this revision.Mar 3 2018, 1:47 PM
mtijink added a subscriber: mtijink.

Looks good!

This revision is now accepted and ready to land.Mar 3 2018, 1:47 PM
Closed by commit R225:959c7c722033: Correctly handle changing canPlay, canPause, canGoNext and canGoPrevious (authored by nicolasfella). · Explain WhyMar 3 2018, 2:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 28484

View Options

src/org/kde/kdeconnect/Plugins/MprisPlugin/MprisPlugin.java

Loading...