Support encrypted mails forwarding
ClosedPublic
Actions

Authored by rnicole on Mar 2 2018, 10:49 AM.

Details

Reviewers

cmollekopf

Maniphest Tasks

Commits

Summary

Some notes:

What we do is: if the mail is encrypted, decrypt it and copy its content into a new message (with plaintext, html and attachments, if any), and use this message as attachment for forwarding
The isEncrypted function from KMime doesn't seem to detect every kind of encrypted mails. AFAIK this structure is not detected:
- multipart/mixed
  - text/plain
  - application/pgp-encrypted (attachement, named "ATT00001")
  - application/octet-stream (attachment named "encrypted.asc")

Repository

R162 Kube

Lint

Lint Skipped

Unit

Unit Tests Skipped

rnicole requested review of this revision.Mar 2 2018, 10:49 AM

rnicole created this revision.

This revision was not accepted when it landed; it landed in state Needs Review.Mar 2 2018, 11:19 AM

This revision was automatically updated to reflect the committed changes.

Now works with messages that have attachments, and do the proper encoding.
Also, now with some tests

Note: the encoding is not tested for now

Rebase on develop because of merge conflict in "framework/src/domain/mime/mimetreeparser/tests/CMakeLists.txt"

			Path	Packages
M			framework/src/domain/composercontroller.cpp (21 lines)
M			framework/src/domain/mime/mailtemplates.cpp (82 lines)
M			framework/src/domain/mime/mimetreeparser/tests/CMakeLists.txt (2 lines)
V			framework/src/domain/mime/mimetreeparser/tests/{interfacetest.cpp → mimetreeparsertest.cpp}
V			framework/src/domain/mime/mimetreeparser/tests/{mimetreeparsertest.cpp ← interfacetest.cpp} (2 lines)
M			framework/src/domain/mime/tests/mailtemplatetest.cpp (49 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	28383			Mar 2 2018, 10:41 AM	★	★
Diff 2	28390	03e8aab	R162:f28ec43dca5b2915deb69d54fb942ddf1303f48c	Mar 2 2018, 11:07 AM	★	★
Diff 3	28413			Mar 2 2018, 3:15 PM	★	★
Diff 4	28999			Mar 8 2018, 11:07 AM	★	★