adding directories history that users selected to the arkrc, so that QuickExtractMenu can read from and display properly.
Related :
https://.kde.org/show_bug.cgi?=357225
elvisangelaccio | |
rthomsen |
adding directories history that users selected to the arkrc, so that QuickExtractMenu can read from and display properly.
Related :
https://.kde.org/show_bug.cgi?=357225
Lint Skipped |
Unit Tests Skipped |
Code looks good. I tested it and seems to work properly.
kerfuffle/extractiondialog.cpp | ||
---|---|---|
157 ↗ | (On Diff #2641) | Please start comments with capital letter and end them with period '.' |
Nice work, just some little changes :)
kerfuffle/extractiondialog.cpp | ||
---|---|---|
158 ↗ | (On Diff #2641) | We already have an "ExtractDialog" config group name, let's re-use it. No need to create a new group with name "ExtractDialog DirHistory" ;) |
159 ↗ | (On Diff #2641) | Please call this entry "DirHistory", which is more explicative than "Item". |
165 ↗ | (On Diff #2641) | Same here, "DirHistory" instead of "Item". |
part/part.cpp | ||
453 ↗ | (On Diff #2641) | Same here, change the name of the config group and the entry below. |