adding directories history that users selected to the arkrc, so that QuickExtractMenu can read from and display properly.
Related :
https://.kde.org/show_bug.cgi?=357225
Details
Details
- Reviewers
elvisangelaccio rthomsen - Maniphest Tasks
- T1781: Fix the quickextract menu
- Commits
- R36:0dbbf028c665: Bring back the quick-extract menu
Diff Detail
Diff Detail
- Repository
- R36 Ark
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Code looks good. I tested it and seems to work properly.
| kerfuffle/extractiondialog.cpp | ||
|---|---|---|
| 157 | Please start comments with capital letter and end them with period '.' | |
Comment Actions
Nice work, just some little changes :)
| kerfuffle/extractiondialog.cpp | ||
|---|---|---|
| 158 | We already have an "ExtractDialog" config group name, let's re-use it. No need to create a new group with name "ExtractDialog DirHistory" ;) | |
| 159 | Please call this entry "DirHistory", which is more explicative than "Item". | |
| 165 | Same here, "DirHistory" instead of "Item". | |
| part/part.cpp | ||
| 453 | Same here, change the name of the config group and the entry below. | |