Differential D10939

KeyboardTranslator: Accept non-alpha-numeric keys
AbandonedPublic
Actions

Authored by hindenburg on Mar 1 2018, 12:17 PM.

Details

Reviewers
vpanteleev
Group Reviewers
Konsole
Summary

Allow rebinding key combinations such as Ctrl+% (Ctrl+Shift+5).

Saving is still broken, but at least this allows editing by hand or generating keymap files and using them with Konsole.

Test Plan
  • Create ~/.local/share/konsole/Test.keytab with:
keyboard "Test"
key &+Ctrl : "test"
  • Open Konsole and select the keytab in the current profile option
  • Press Ctrl+& (Ctrl+Shift-7 on QWERTY/US)

Should result in "test" being printed.

Actually no idea what to put in this field, https://community.kde.org/Infrastructure/Github_Mirror or https://community.kde.org/Infrastructure/Phabricator didn't mention it.

Diff Detail

Repository
R319 Konsole
Lint
Lint Skipped
Unit
Unit Tests Skipped
vpanteleev requested review of this revision.Mar 1 2018, 12:17 PM
vpanteleev created this revision.
vpanteleev edited the test plan for this revision. (Show Details)Mar 1 2018, 12:22 PM
vpanteleev edited the summary of this revision. (Show Details)
hindenburg added a subscriber: hindenburg.Mar 2 2018, 4:25 PM

Thanks, I'll look at this

hindenburg commandeered this revision.May 30 2018, 4:01 AM
hindenburg added a reviewer: vpanteleev.
Restricted Application added a subscriber: konsole-devel. · View Herald TranscriptMay 30 2018, 4:01 AM
hindenburg abandoned this revision.May 30 2018, 4:02 AM

A slightly different patch was committed for 18.08; regardless, thanks for the patch

Revision Contents
Changeset List

PathPackages
Msrc/KeyboardTranslator.cpp (2 lines)

Diff 28316

View Options

src/KeyboardTranslator.cpp

Loading...