Differential D10827

Put keyboard button in navigation bar when possible
ClosedPublic
Actions

Authored by mtijink on Feb 25 2018, 11:13 AM.

Details

Reviewers
nicolasfella
Group Reviewers
KDE Connect
Commits
R225:abc5526252f6: Put keyboard button in navigation bar when possible
Summary

In the remote input activity, the keyboard button was in the overflow menu, even though it fit on the navigation bar. The previous code used the wrong namespace, so this fixes it.

BUG: 390640

Before:

After:

Diff Detail

Repository
R225 KDE Connect - Android application
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mtijink requested review of this revision.Feb 25 2018, 11:13 AM
mtijink created this revision.
mtijink edited the summary of this revision. (Show Details)Feb 25 2018, 11:13 AM
nicolasfella accepted this revision.Feb 25 2018, 12:33 PM
nicolasfella added a subscriber: nicolasfella.

Nice!

This revision is now accepted and ready to land.Feb 25 2018, 12:33 PM
Closed by commit R225:abc5526252f6: Put keyboard button in navigation bar when possible (authored by mtijink). · Explain WhyFeb 25 2018, 3:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mres/menu/menu_mousepad.xml (2 lines)

Diff 28037

View Options

res/menu/menu_mousepad.xml

Loading...