Differential D1082

[kcm] Remove QQuickView for themes
ClosedPublic
Actions

Authored by graesslin on Mar 8 2016, 12:34 PM.

Details

Reviewers

bshah

Group Reviewers

Plasma

Commits

R133:47d3969ef306: [kcm] Remove QQuickView for themes

Summary

[kcm] Remove QQuickView for themes

The feature for theme selection in lock screen never got implemented.
It doesn't list any themes by default and is causing bugs. So better
remove it. Lock screen uses look and feel packages by default, so it
is themeable.

BUG: 352650
FIXED-IN: 5.6.0

Diff Detail

Repository

R133 KScreenLocker

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

graesslin updated this revision to Diff 2608.Mar 8 2016, 12:34 PM

graesslin retitled this revision from to Only require Qt 5.4.

graesslin updated this object.

graesslin edited the test plan for this revision. (Show Details)

graesslin added a reviewer: Plasma.

Restricted Application added a project: Plasma. · View Herald TranscriptMar 8 2016, 12:34 PM

Restricted Application added a subscriber: plasma-devel. · View Herald Transcript

Looks good to me.

This revision is now accepted and ready to land.Mar 8 2016, 12:39 PM

graesslin updated this revision to Diff 2611.Mar 8 2016, 1:10 PM

graesslin retitled this revision from Only require Qt 5.4 to [kcm] Remove QQuickView for themes.

graesslin updated this object.

graesslin edited edge metadata.

graesslin removed R133 KScreenLocker as the repository for this revision.

Accepted given in previous review still stands.

Closed by commit R133:47d3969ef306: [kcm] Remove QQuickView for themes (authored by graesslin). · Explain WhyMar 8 2016, 2:49 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

		Path
M		kcm/CMakeLists.txt (3 lines)
M		kcm/kcm.h (15 lines)
M		kcm/kcm.cpp (87 lines)
M		kcm/kcm.ui (17 lines)
D	M	kcm/package/contents/ui/main.qml (173 lines)
D	M	kcm/package/metadata.desktop (82 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	2608	d934a09		Mar 8 2016, 12:34 PM	★	★
Diff 2	2611			Mar 8 2016, 1:10 PM	★	★
Diff 3	2615	18c35d3	rKSCREENLOCKER47d3969ef306d30ecb4e377c283d9f7df7e2d8a0	Mar 8 2016, 1:07 PM	★	★