Make libdiscover a private library
ClosedPublic

Authored by mak on Mar 7 2016, 6:23 PM.

Details

Summary

This is very useful for distributions, especially Debian, since it silences lint warnings about e.g. missing SONAMES and relaxes the (very strict) checks for this shared library on the distro side in general.
It also limits its use to the Discover project only, but that is it's intended usecase anyway, as internal library.
As a neat side effect, this change also removes any collisions of the library name with other projects (e.g. the existing "discover" project).

Test Plan
  • It builds
  • It installs
  • It runs

I didn't encounter any issues.

Diff Detail

Repository
R134 Discover Software Store
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mak updated this revision to Diff 2603.Mar 7 2016, 6:23 PM
mak retitled this revision from to Make libdiscover a private library.
mak updated this object.
mak edited the test plan for this revision. (Show Details)
mak added a reviewer: apol.
mak set the repository for this revision to R134 Discover Software Store.
mak added a project: Discover Software Store.
mak updated this object.Mar 7 2016, 6:26 PM
apol accepted this revision.Mar 7 2016, 9:50 PM
apol edited edge metadata.

Thanks!

This revision is now accepted and ready to land.Mar 7 2016, 9:50 PM
This revision was automatically updated to reflect the committed changes.