update appMenu status only from qml side
ClosedPublic

Authored by mvourlakos on Feb 21 2018, 12:36 PM.

Details

Summary

--add NeedsAttention status when a menu is showing, and
Passive status when the menu is not available
--remove status updates from plasmoid interface

Test Plan

I used debug messages to confirm the status changes and
also Latte to check that dynamic background now works ok

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mvourlakos created this revision.Feb 21 2018, 12:36 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 21 2018, 12:36 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mvourlakos requested review of this revision.Feb 21 2018, 12:36 PM
broulik accepted this revision.Feb 21 2018, 12:57 PM
broulik added a subscriber: broulik.

BUG: 390271

This revision is now accepted and ready to land.Feb 21 2018, 12:57 PM

@broulik my only concerns are for line:

setStatus(Plasma::Types::AcceptingInputStatus);

do you know if there was any specific reason for it?

AcceptingInputStatus

This was to keep an auto-hidden panel visible but I think the panel (at least Plasma, dunno about latte) is smart enough to stay open when a transient child is open, see 2d8b4e1dec26c5976dd75c238c3ae8a4700b8dd9

mvourlakos added a comment.EditedFeb 21 2018, 1:06 PM

but I think the panel (at least Plasma, dunno about latte) is smart enough to stay open when a transient child is open

no prob then... Latte uses the NeedsAttention from applets to block auto-hiding

This revision was automatically updated to reflect the committed changes.