Differential D1070

Make panel scripting setLength set min and max length
AbandonedPublic
Actions

Authored by davidedmundson on Mar 4 2016, 1:27 PM.

Details

Reviewers
None
Group Reviewers
Plasma
Summary

Setting the length of the panel doesn't do anything useful as it's
overwritten from the QML side as soon as it loads contents. However we
need to keep API on the scripting, so we should make it do what the user
is trying to do of making the panel be an explicit size.

We currently tell users to set min and max explicitly, this does that
for them.

Diff Detail

Repository
R120 Plasma Workspace
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
davidedmundson updated this revision to Diff 2560.Mar 4 2016, 1:27 PM
davidedmundson retitled this revision from to Make panel scripting setLength set min and max length.
davidedmundson updated this object.
davidedmundson edited the test plan for this revision. (Show Details)
Restricted Application added a project: Plasma. · View Herald TranscriptMar 4 2016, 1:27 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
mart added a subscriber: mart.Mar 4 2016, 1:34 PM

hmm, this quite risks to lose min and max settings in unwanted moments..
do you know exactly from where setLength is called and where/when the problem happens?

davidedmundson added a comment.Mar 13 2016, 1:30 AM

This will be used by any custom layout.js files.
We don't use it ourselves. All our layouts are maximised panels.

It's other distros layouts that might use it to make a dock style layout and the current code basically does nothing.

I'd be happy replacing it with a qWarning() << "This method is deprecated, please use setMin..." instead?

davidedmundson abandoned this revision.Aug 18 2017, 12:42 AM

Revision Contents
Changeset List

PathPackages
Mshell/scripting/panel.cpp (12 lines)

Diff 2560

View Options

shell/scripting/panel.cpp

Loading...