[Run Command] Add history drop down button

Authored by broulik on Feb 19 2018, 10:36 AM.



Indicates that there's a "drop down" history similar to a ComboBox. The fact that you can press the down arrow to bring it up is hardly discoverable.

BUG: 375207
FIXED-IN: 5.13.0

Test Plan

When the text field is empty, a drop down arrow is shown in the text field. As soon as you type it is replaced by the regular "clear" button

Diff Detail

R120 Plasma Workspace
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Feb 19 2018, 10:36 AM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 19 2018, 10:36 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 19 2018, 10:36 AM

Indeed; I never discovered it! This is great.


Do we have a programmatic value we can use here instead of a magic number?


Ditto; maybe we should make units.iconSizes.small reflect the actual size that we want and just use that?

Those magic values are copied straight from Plasma TextFieldStyle

I imagine refactoring that not to use magic numbers is a bigger effort. Still, we should keep that in mind, I think.

ngraham accepted this revision as: VDG.Feb 19 2018, 2:08 PM

VDG-wise, big thumbs up. This is a clear usability improvement.

This revision was not accepted when it landed; it landed in state Needs Review.Feb 19 2018, 2:09 PM
This revision was automatically updated to reflect the committed changes.
mbele added a subscriber: mbele.Feb 20 2018, 11:44 AM

Wonderful! The famous arrow has come back! It should not have been removed in the first place!

firef awarded a token.Feb 20 2018, 2:08 PM