Differential D1064

Move the notifier to a global static
ClosedPublic
Actions

Authored by ervin on Mar 2 2016, 10:21 PM.

Details

Reviewers
bensi
dfaure
franckarrecot
Commits
R4:d862a43ca8f9: Move the notifier to a global static
Summary

This is necessary to fix a leak when the DataSourceQueries interface is
used through MockObject. We don't go through ctor/dtor in such cases as
we're supposed to have pure interfaces with no data. The notifier in
fact doesn't need to be held by every instances of that interface so
share it using a global static.

Diff Detail

Repository
R4 Zanshin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
ervin updated this revision to Diff 2540.Mar 2 2016, 10:21 PM
ervin retitled this revision from to Move the notifier to a global static.
ervin updated this object.
ervin edited the test plan for this revision. (Show Details)
ervin added reviewers: bensi, franckarrecot, dfaure.
bensi accepted this revision.Mar 3 2016, 12:08 PM
bensi edited edge metadata.
This revision is now accepted and ready to land.Mar 3 2016, 12:08 PM
Closed by commit R4:d862a43ca8f9: Move the notifier to a global static (authored by ervin). · Explain WhyMar 6 2016, 4:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2594

View Options

src/domain/datasourcequeries.h

Loading...
View Options

src/domain/datasourcequeries.cpp

Loading...