Differential D10615

Planegame, fixed clouds propogation behind bar
ClosedPublic
Actions

Authored by asagtani on Feb 17 2018, 8:03 PM.

Details

Reviewers
jjazeix
Group Reviewers
GCompris: Improvements
Summary

Previously clouds were generated at the random height of the window, some time clouds were generated at the same level as the bar and they got hidden behind the bar. (https://snag.gy/m5KFXQ.jpg)

Fixed the cloud generation between background.top and bar.top, and limited movement of plane up to bar.top

TODO: Fix position of hint (https://snag.gy/Sv47MV.jpg) it is overriding bar buttons in vertical mode. The best options are top right and top left, needs to be discussed.

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
asagtani created this revision.Feb 17 2018, 8:03 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptFeb 17 2018, 8:03 PM
Restricted Application added a subscriber: KDE Edu. · View Herald Transcript
asagtani requested review of this revision.Feb 17 2018, 8:03 PM
jjazeix added a subscriber: jjazeix.Feb 20 2018, 9:49 PM

Fix looks good to me.
For the letter to guess, I would put it above the bar on right side to have the same as other activities.
I think we can also reduce its height to the letter height plus some margin

asagtani updated this revision to Diff 27654.Feb 21 2018, 4:05 AM

Fixed letter to guess position and dimensions.
For vertical mode --> https://cdn.pbrd.co/images/H8BU1Nh.png
For horizontal mode --> https://cdn.pbrd.co/images/H8BVeBd.png

jjazeix accepted this revision.Mar 9 2018, 7:44 AM

can you commit it on master please?

Thank you for the fix

This revision is now accepted and ready to land.Mar 9 2018, 7:44 AM

Revision Contents
Changeset List

Diff 27654

View Options

src/activities/planegame/Cloud.qml

Loading...
View Options

src/activities/planegame/Planegame.qml

Loading...
View Options

src/activities/planegame/planegame.js

Loading...