Differential D10546

[Kickoff] Turn ActionMenu into a QtObject
AbandonedPublic
Actions

Authored by broulik on Feb 15 2018, 2:23 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Summary

It's not a visual item and the PlasmaComponents.Menu is also just a regular QObject, no point in our menu wrapper being an Item.

Test Plan

Menu still shows up correctly, favorites action still works

Diff Detail

Repository
R119 Plasma Desktop
Lint
Lint Skipped
Unit
Unit Tests Skipped
broulik created this revision.Feb 15 2018, 2:23 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 15 2018, 2:23 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Feb 15 2018, 2:23 PM
davidedmundson accepted this revision.Feb 15 2018, 2:26 PM
This revision is now accepted and ready to land.Feb 15 2018, 2:26 PM
broulik abandoned this revision.Feb 15 2018, 2:29 PM

PlasmaComponents.MenuItem is a QQuickItem, for whatever reason, I suspect for recursive enabled/visible handling, and with my patch it then complains about not having been placed in a scene.

Revision Contents
Changeset List

Diff 27261

View Options

applets/kickoff/package/contents/ui/ActionMenu.qml

Loading...