Differential D1051

Make use of CXTranslationUnit_KeepGoing
ClosedPublic
Actions

Authored by kfunk on Mar 2 2016, 8:43 PM.

Details

Reviewers
mwolff
Commits
R32:8af21faaa886: clang: Make use of CXTranslationUnit_KeepGoing
Summary

CCBUG: 358853

Diff Detail

Repository
R32 KDevelop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
kfunk updated this revision to Diff 2521.Mar 2 2016, 8:43 PM
kfunk retitled this revision from to Make use of CXTranslationUnit_KeepGoing.
kfunk updated this object.
kfunk edited the test plan for this revision. (Show Details)
Restricted Application added a subscriber: kdevelop-devel. · View Herald TranscriptMar 2 2016, 8:43 PM
kfunk added a reviewer: mwolff.Mar 2 2016, 8:44 PM
kfunk added a project: KDevelop.
kfunk updated this revision to Diff 2522.Mar 2 2016, 8:44 PM

Fix commit message

kfunk updated this object.Mar 2 2016, 8:45 PM
mwolff requested changes to this revision.Mar 2 2016, 8:51 PM
mwolff edited edge metadata.
mwolff added inline comments.
languages/clang/tests/test_duchain.cpp
307

this will break for older versions of clang, as there we only get one problem, not two. can you either ifdef it as well, or Abort earlier?

This revision now requires changes to proceed.Mar 2 2016, 8:51 PM
kfunk updated this revision to Diff 2523.Mar 2 2016, 8:53 PM
kfunk edited edge metadata.

Address concerns

kfunk updated this revision to Diff 2524.Mar 2 2016, 8:58 PM
kfunk edited edge metadata.

Try again

mwolff added inline comments.Mar 2 2016, 8:59 PM
languages/clang/tests/test_duchain.cpp
304–310

this should still be 1 :P

kfunk updated this revision to Diff 2525.Mar 2 2016, 8:59 PM

Fix for sure

kfunk updated this revision to Diff 2526.Mar 2 2016, 9:01 PM

Let's see if I got it right this time

mwolff accepted this revision.Mar 2 2016, 9:22 PM
mwolff edited edge metadata.
This revision is now accepted and ready to land.Mar 2 2016, 9:22 PM
Closed by commit R32:8af21faaa886: clang: Make use of CXTranslationUnit_KeepGoing (authored by kfunk). · Explain WhyMar 2 2016, 9:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 2527

View Options

languages/clang/duchain/parsesession.cpp

Loading...
View Options

languages/clang/tests/test_duchain.cpp

Loading...