Details
- Reviewers
- None
- Commits
- R32:39f851d3e424: Template for C, with CMake
Diff Detail
- Repository
- R32 KDevelop
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
LGTM, nitpicking.
app_templates/c/CMake/cmake_plainc/main.c | ||
---|---|---|
8 | return 0; is best, the compiler will turn it into an exit call. |
+1
app_templates/c/CMake/cmake_plainc/CMakeLists.txt | ||
---|---|---|
2 | This being a template, better use a lower number here, like 3.0 | |
app_templates/c/CMake/cmake_plainc/cmake_plainc.kdevtemplate | ||
5 | All the translations can be removed. KDE's automated translation system has a separate database with all the translations, which is filled directly by the translators with translations (actually pp files in a svn repo). So once this is in, and due to the original strings not yet extracted into the database and thus no translations existing, all the translations here will be removed on the first run of the script. So no need to have them here from the start. Just keep the | |
38 | Same as for Name translations. Just keep the Comment=Simple CMake-based C application line. |
app_templates/c/CMake/cmake_plainc/main.c | ||
---|---|---|
8 | This goes down to personal preference, discussing this is trivial so I'll comply. That excludes the need for stdlib.h but I am keeping it for the sake of convenience. |
You do not yet have earned push rights for KDE git servers, right? So one of us would do this for you.
What is the author data (firstname lastname <email>) we can use to give credit to you here?