Differential D10478

messagelist: Save current selection at exit
ClosedPublic
Actions

Authored by aleksejshilin on Feb 13 2018, 7:07 AM.

Details

Reviewers
mlaurent
Group Reviewers
KDE PIM
Commits
R94:fbfa271f6d2d: Patch from aleksejshilin
Summary

Previously, current message selection was saved only when switching
collections. As the result, selection changes were not always saved,
breaking the PreSelectLastSelected mode (which is the default one in
e.g. KMail).

This commit fixes the issue by saving current selection at tab close
and at Pane destruction (i.e. application exit).

Diff Detail

Repository
R94 PIM: Message Library
Branch
save_selection_on_close
Lint
No Linters Available
Unit
No Unit Test Coverage
aleksejshilin created this revision.Feb 13 2018, 7:07 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 13 2018, 7:07 AM
aleksejshilin requested review of this revision.Feb 13 2018, 7:07 AM
mlaurent requested changes to this revision.Feb 13 2018, 8:05 AM
mlaurent added a subscriber: mlaurent.
mlaurent added inline comments.
messagelist/src/pane.cpp
609

if (wWidget) is enough

This revision now requires changes to proceed.Feb 13 2018, 8:05 AM
aleksejshilin added inline comments.Feb 13 2018, 10:34 AM
messagelist/src/pane.cpp
609

if (wWidget) is enough

I know. :) It's just my habitual coding style slipping through.
I'll update the revision right away.

aleksejshilin updated this revision to Diff 27045.Feb 13 2018, 10:40 AM
  • Use proper coding style
mlaurent accepted this revision.Feb 13 2018, 12:26 PM

Thanks.
Do you want that I commit it for you ?

This revision is now accepted and ready to land.Feb 13 2018, 12:26 PM
aleksejshilin added a comment.Feb 13 2018, 12:45 PM
In D10478#205402, @mlaurent wrote:

Do you want that I commit it for you ?

Definitely yes. :) Thanks!

Closed by commit R94:fbfa271f6d2d: Patch from aleksejshilin (authored by mlaurent). · Explain WhyFeb 13 2018, 12:52 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mmessagelist/src/pane.cpp (7 lines)

Diff 27045

View Options

messagelist/src/pane.cpp

Loading...