Differential D10391

Ensure Registry gets destroyed before the Wayland connection
ClosedPublic
Actions

Authored by graesslin on Feb 8 2018, 5:59 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R102:a7e887975d01: Ensure Registry gets destroyed before the Wayland connection
Summary

Registry was parented to WaylandModule, but the ConnectionThread got
destroyed in the dtor, thus before the Registry resulting in a crash
when the Registry got destroyed.

This change addresses this problem by tracking the Registry and
destroying it before destroying the Connection.

BUG: 387479
FIXED-IN: 5.12.1

Test Plan

Clicked Wayland section, then quit application, verified
exit code

Diff Detail

Repository
R102 KInfoCenter
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Feb 8 2018, 5:59 PM
Restricted Application added a project: Plasma. · View Herald TranscriptFeb 8 2018, 5:59 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
graesslin requested review of this revision.Feb 8 2018, 5:59 PM
davidedmundson accepted this revision.Feb 8 2018, 6:01 PM
This revision is now accepted and ready to land.Feb 8 2018, 6:01 PM
Closed by commit R102:a7e887975d01: Ensure Registry gets destroyed before the Wayland connection (authored by graesslin). · Explain WhyFeb 8 2018, 6:18 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 26782

View Options

Modules/base/info_wayland.h

Loading...
View Options

Modules/base/info_wayland.cpp

Loading...