Differential D10367

Fix color bar painting failures in statistics main window
ClosedPublic
Actions

Authored by hriesenbeck on Feb 7 2018, 5:14 PM.

Details

Reviewers
tcanabrava
Group Reviewers
KDE Edu
Commits
R340:d3fc379d415b: Fix color bar painting failures in statistics main window
Summary

Some color bars of the bar chart in LessonStatisticsView are not drawn
to its full length. The reason are rounding errors in bar segment length
calculation. To fix this, all integer values were replaced by floating
point variables.

Furthermore sometimes the border line between two bar segments was not
drawn when constructed with QPainterPath. The relevant QPainterPath
operation were replaced by direct drawing operations to the QPainter
object.

BUG: 389998

Diff Detail

Repository
R340 Parley
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
hriesenbeck created this revision.Feb 7 2018, 5:14 PM
Restricted Application added a project: KDE Edu. · View Herald TranscriptFeb 7 2018, 5:14 PM
hriesenbeck requested review of this revision.Feb 7 2018, 5:14 PM
hriesenbeck added a comment.Mar 1 2018, 8:47 PM

Please review

tcanabrava added a subscriber: tcanabrava.Nov 2 2018, 4:19 PM

Can you post a screenshoot of the before / after?

Restricted Application added a subscriber: kde-edu. · View Herald TranscriptNov 2 2018, 4:19 PM
hriesenbeck added a comment.Nov 3 2018, 4:40 PM

Thank you for reply!
Here are the screen shots:

StatisticsMainWindow before bugfix

StatisticsMainWindow after bugfix

Detail view of bar length failure before bugfix

Detail view of bar length failure after bugfix

Detail views of border line failure before bugfix

Detail views of border line failure after bugfix

tcanabrava accepted this revision.Nov 15 2018, 1:37 PM
This revision is now accepted and ready to land.Nov 15 2018, 1:37 PM
Closed by commit R340:d3fc379d415b: Fix color bar painting failures in statistics main window (authored by hriesenbeck). · Explain WhyNov 15 2018, 7:34 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/utils.cpp (34 lines)

Diff 45542

View Options

src/utils.cpp

Loading...