Make it possible to compile 5.12 branch with a kdecoration from master
ClosedPublic

Authored by graesslin on Feb 4 2018, 2:36 PM.

Details

Summary

KDecoration has two new pure virtual methods. Due to that one cannot
build KWin in the stable branch. This makes bug fixing rather cumbersome
as one also needs to switch the kdecoration branch.

This rather unusual change for a stable branch improves the
compatibility by adding the new virtual methods without doing anything
and without marking them as override, so that the code can compile with
a kdecoration from 5.12 and a kdecoration from master.

Test Plan

5.12 branch compiles with kdecoration master branch

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Feb 4 2018, 2:36 PM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 4 2018, 2:36 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
graesslin requested review of this revision.Feb 4 2018, 2:36 PM
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptFeb 4 2018, 2:36 PM
davidedmundson accepted this revision.Feb 4 2018, 6:00 PM
This revision is now accepted and ready to land.Feb 4 2018, 6:00 PM
Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptFeb 4 2018, 6:00 PM
This revision was automatically updated to reflect the committed changes.
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptFeb 7 2018, 6:44 PM