Differential D10294

Init the icon in ShellClient::init
ClosedPublic
Actions

Authored by graesslin on Feb 4 2018, 1:21 PM.

Details

Reviewers
bshah
Group Reviewers
KWin
Plasma
Commits
R108:5795fc8cc04a: Init the icon in ShellClient::init
Summary

If the window never provides the appId, we would not get an icon for
the window. This happens for example for KWin's internal windows which
don't set the app id as KWin also doesn't have a desktop file. With this
change the DebugConsole has a window icon in the decoration.

Test Plan

Extended tests and manual verification of DebugConsole

Diff Detail

Repository
R108 KWin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
graesslin created this revision.Feb 4 2018, 1:21 PM
Restricted Application added a project: KWin. · View Herald TranscriptFeb 4 2018, 1:21 PM
Restricted Application added subscribers: kwin, plasma-devel. · View Herald Transcript
graesslin requested review of this revision.Feb 4 2018, 1:21 PM
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptFeb 4 2018, 1:21 PM
Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptFeb 21 2018, 5:09 PM
bshah accepted this revision.Feb 23 2018, 5:28 AM
This revision is now accepted and ready to land.Feb 23 2018, 5:28 AM
Restricted Application edited projects, added Plasma; removed KWin. · View Herald TranscriptFeb 23 2018, 5:28 AM
Closed by commit R108:5795fc8cc04a: Init the icon in ShellClient::init (authored by graesslin). · Explain WhyFeb 25 2018, 1:11 PM
This revision was automatically updated to reflect the committed changes.
Restricted Application edited projects, added KWin; removed Plasma. · View Herald TranscriptFeb 25 2018, 1:11 PM

Revision Contents
Changeset List

Diff 28021

View Options

autotests/integration/internal_window.cpp

Loading...
View Options

autotests/integration/shell_client_test.cpp

Loading...
View Options

shell_client.cpp

Loading...