This removes the custom RubberBand that is painted using QStyle and instead uses a traditional Rectangle.
We don't use "Desktop Widget Style" in Plasma anyway. The rubber band now follows the theme's highlight color and has a nice fade animation when it disappears.
Rubber band selection works fine.
Repeated quick moving and selecting doesn't make it go nuts, even when the fade out animation is still running.
Auto scroll in both popup and as containment is erratic; not sure if this is caused by this patch, however.
Using Tilain the rubber band is now white, for example, using Oxygen it's a fainter blue.
I did not yet remove the RubberBand cpp stuff as I wanted to get some feedback first before messing up my local repository :)
| Lint Skipped |
| Unit Tests Skipped |
I'm not sure I'm on board with this - in absence of a proper Plasma Rubberband "standard", going with the QStyle one seemed (and seems) like a sane default for me. Some users also want rubberbands with just outlines, marching ants because of vision problems, whatever and this removes any sort of theming control from the rubberband. I think if we want to get rid of the CPP rubberband we need to add a rubberband element to the Plasma themes.