Differential D10222

Don't insert invalid google accounts into the access list
ClosedPublic
Actions

Authored by davidk on Feb 1 2018, 8:10 AM.

Details

Reviewers
dvratil
Commits
R44:ea2ec0926f8e: Don't insert invalid google accounts into the access list
Summary

This prevents accounts to be inserted into the list, if the user
presses the cancel button or doesn't authenticate.
Requires D10221.

Test Plan

The accounts aren't inserted into the access list in KAddressbook,
if I press cancel or don't grant the access scopes.

Diff Detail

Repository
R44 KDE PIM Runtime
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidk created this revision.Feb 1 2018, 8:10 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 1 2018, 8:10 AM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
davidk requested review of this revision.Feb 1 2018, 8:10 AM
dvratil accepted this revision.Feb 1 2018, 8:31 AM
dvratil added a subscriber: dvratil.

Thanks! This change does not make much sense without the libkgapi patch, right? If so, then it should go only to master.

This revision is now accepted and ready to land.Feb 1 2018, 8:31 AM
davidk added a comment.Feb 1 2018, 10:30 AM

The change improves the current state in case the user doesn't grant the access scopes. Only if the user presses the cancel button, the change in libkgapi is needed. So I think it makes sense in 17.12.

dvratil added a comment.Feb 1 2018, 10:40 AM

Ok, 17.12 it is.

davidk updated this revision to Diff 26332.Feb 1 2018, 4:24 PM
This comment was removed by davidk.
Closed by commit R44:ea2ec0926f8e: Don't insert invalid google accounts into the access list (authored by davidk). · Explain WhyFeb 1 2018, 4:28 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 26333

View Options

resources/google/common/googlesettingsdialog.cpp

Loading...