Differential D10221

Set error if oauth dialog is aborted
ClosedPublic
Actions

Authored by davidk on Feb 1 2018, 7:59 AM.

Details

Reviewers
dvratil
Commits
R477:08182df35c08: Set error if oauth dialog is aborted
Summary

Also, connect the signals of the auth widget in one place.
This makes it easier to understand.

Test Plan
  • Error is set if user presses the cancel button
  • Toghether with a change in kdepim-runtime, there are no more invalid entries in the access list

Diff Detail

Repository
R477 KGAPI Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidk created this revision.Feb 1 2018, 7:59 AM
Restricted Application added a project: KDE PIM. · View Herald TranscriptFeb 1 2018, 7:59 AM
davidk requested review of this revision.Feb 1 2018, 7:59 AM
davidk added a comment.Feb 1 2018, 8:11 AM

kdepim-runtime RR: D10222

dvratil added a comment.Feb 1 2018, 8:28 AM

You are on a roll!

src/core/authjob.cpp
248

Just "Authentication canceled" would be better I think. The current string sounds like we are trying to make the user feel bad for canceling it. What do you think?

davidk added inline comments.Feb 1 2018, 10:31 AM
src/core/authjob.cpp
248

Yes, "Authentication canceled" sounds much better. I will change it.

davidk updated this revision to Diff 26334.Feb 1 2018, 4:38 PM

Improve uservisible message.

davidk marked 2 inline comments as done.Feb 1 2018, 4:39 PM

So shall this go into master or 17.12? It needs the change in kdepim-runtime to improve things.

dvratil accepted this revision.Feb 1 2018, 4:44 PM

This can't go to 17.12 because of the new translatable string. Only master.

This revision is now accepted and ready to land.Feb 1 2018, 4:44 PM
Closed by commit R477:08182df35c08: Set error if oauth dialog is aborted (authored by davidk). · Explain WhyFeb 1 2018, 4:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/authjob.cpp (21 lines)

Diff 26335

View Options

src/core/authjob.cpp

Loading...