Also, connect the signals of the auth widget in one place.
This makes it easier to understand.
Details
Details
- Reviewers
dvratil - Commits
- R477:08182df35c08: Set error if oauth dialog is aborted
- Error is set if user presses the cancel button
- Toghether with a change in kdepim-runtime, there are no more invalid entries in the access list
Diff Detail
Diff Detail
- Repository
- R477 KGAPI Library
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
You are on a roll!
src/core/authjob.cpp | ||
---|---|---|
248 | Just "Authentication canceled" would be better I think. The current string sounds like we are trying to make the user feel bad for canceling it. What do you think? |
src/core/authjob.cpp | ||
---|---|---|
248 | Yes, "Authentication canceled" sounds much better. I will change it. |
Comment Actions
So shall this go into master or 17.12? It needs the change in kdepim-runtime to improve things.