Differential D10206

Fix oauth focus
ClosedPublic
Actions

Authored by davidk on Jan 31 2018, 4:46 PM.

Details

Reviewers
dvratil
mlaurent
Commits
R477:1ad3e82403e2: Fix oauth focus
Summary

Set the focus to the webview. Previously, if you entered an e-mail address
and pressed enter, it would have closed the webview, because the cancel button
is the default button. I think this is a QT bug, so I opened a QT bugreport.

BUG: 389263

Test Plan
  • In KMail, the focus works now
  • In KOrganizer, the focus works now

Diff Detail

Repository
R477 KGAPI Library
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
davidk created this revision.Jan 31 2018, 4:46 PM
Restricted Application added a project: KDE PIM. · View Herald TranscriptJan 31 2018, 4:46 PM
Restricted Application added a subscriber: KDE PIM. · View Herald Transcript
davidk requested review of this revision.Jan 31 2018, 4:46 PM
dvratil accepted this revision.Jan 31 2018, 5:24 PM

Thanks, I recently hit this too and I just couldn't remember if it has always been like that of if that's a regression :-)

This revision is now accepted and ready to land.Jan 31 2018, 5:24 PM
davidk added a comment.Jan 31 2018, 7:45 PM

Shall I push it to 17.12?

dvratil added a comment.Jan 31 2018, 8:39 PM
In D10206#198698, @davidk wrote:

Shall I push it to 17.12?

Yes, please.

Closed by commit R477:1ad3e82403e2: Fix oauth focus (authored by davidk). · Explain WhyFeb 1 2018, 6:45 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/core/authjob.cpp (3 lines)
Msrc/core/ui/authwidget.cpp (1 line)

Diff 26301

View Options

src/core/authjob.cpp

Loading...
View Options

src/core/ui/authwidget.cpp

Loading...