Differential D10192

Fix crash when changing file download order
ClosedPublic
Actions

Authored by jguderzo on Jan 30 2018, 2:17 PM.

Details

Reviewers
stikonas
Commits
R473:722c21e56d9e: Fix crash when changing file download order
R473:623c75b86840: Fix crash when changing file download order
Summary

DownloadOrderDialog::commitDownloadOrder() is connected to the accepted
signal, calling accept() inside it causes a loop.

BUG: 384371

Diff Detail

Repository
R473 KTorrent
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
jguderzo requested review of this revision.Jan 30 2018, 2:17 PM
jguderzo created this revision.
stikonas accepted this revision.Jan 30 2018, 2:19 PM

Looks good. Please commit.

This revision is now accepted and ready to land.Jan 30 2018, 2:19 PM
jguderzo added a comment.Jan 30 2018, 2:33 PM
In D10192#198096, @stikonas wrote:

Looks good. Please commit.

Sorry, can't commit. I don't have a developer account.

stikonas added a comment.Jan 30 2018, 2:33 PM

No problem, I'll commit then. Thanks

stikonas added a comment.Jan 30 2018, 2:36 PM
In D10192#198099, @jguderzo wrote:
In D10192#198096, @stikonas wrote:

Looks good. Please commit.

Sorry, can't commit. I don't have a developer account.

Hmm, I still need your email address to credit you in git commit --author.
Can you somehow tell it? Either here, or email me...

jguderzo added a comment.Jan 30 2018, 2:47 PM

Thanks, mail is crazyhg@gmail.com

Closed by commit R473:722c21e56d9e: Fix crash when changing file download order (authored by jguderzo, committed by stikonas). · Explain WhyJan 30 2018, 2:50 PM
This revision was automatically updated to reflect the committed changes.
stikonas added a comment.Jan 30 2018, 2:59 PM

Thanks again. Submitted. Note that if you continue to plan to work on KTorrent or other KDE projects, you can get a commit access after a few patches.

Revision Contents
Changeset List

Diff 26214

View Options

plugins/downloadorder/downloadorderdialog.cpp

Loading...