Differential D10067

[Look and feel KCM] Destroy and recreate GHNS button when palette changes
ClosedPublic
Actions

Authored by broulik on Jan 24 2018, 8:56 AM.

Details

Reviewers
mart
Group Reviewers
Plasma
Commits
R119:900a334e72a7: [Look and feel KCM] Destroy and recreate GHNS button when palette changes
Summary

BUG: 389351
FIXED-IN: 5.12.0

Test Plan

See comment in the code.

  • GHNS dialog still shows
  • Changed from Breeze to Breeze dark, GHNS button updated immediately. Interestingly the check box updates just fine.

I tried various other workarounds, such as an event filter installed by Breeze style to repaint or clear caches, I inspected the qquickstyleitem code to find a clue as to how trigger an update of its styleOption from outside but I didn't find one and franky I also didn't care enough.

Diff Detail

Repository
R119 Plasma Desktop
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
broulik created this revision.Jan 24 2018, 8:56 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 24 2018, 8:56 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
broulik requested review of this revision.Jan 24 2018, 8:56 AM
mart accepted this revision.Jan 26 2018, 1:02 PM
mart added a subscriber: mart.

ok for now (note that we will be able to use qqc2 buttons with icons only when we can depend at least for plasma-desktop on Qt 5.10)

This revision is now accepted and ready to land.Jan 26 2018, 1:02 PM
Closed by commit R119:900a334e72a7: [Look and feel KCM] Destroy and recreate GHNS button when palette changes (authored by broulik). · Explain WhyJan 26 2018, 3:23 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 25995

View Options

kcms/lookandfeel/package/contents/ui/main.qml

Loading...