Differential D10066

Add touchpad shortcuts to the whitelist
ClosedPublic
Actions

Authored by dos on Jan 24 2018, 1:23 AM.

Details

Reviewers
graesslin
Group Reviewers
Plasma
Commits
R133:e861e10d84c8: Add touchpad shortcuts to the whitelist
Summary

My laptop's ACPI has a weird habit of sending the touchpad toggle key stroke when closing the lid, so the shortcut to enable the touchpad turns out to be handy even when the screen is locked.

Test Plan

The touchpad should be enabled/disabled after pressing the button when the screen is locked.

Diff Detail

Repository
R133 KScreenLocker
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
dos created this revision.Jan 24 2018, 1:23 AM
Restricted Application added a project: Plasma. · View Herald TranscriptJan 24 2018, 1:23 AM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
dos requested review of this revision.Jan 24 2018, 1:23 AM
graesslin requested changes to this revision.Jan 24 2018, 5:27 AM
graesslin added a subscriber: graesslin.
graesslin added inline comments.
globalaccel.cpp
59

This won't work on Wayland as there KWin holds the shortcut.

This revision now requires changes to proceed.Jan 24 2018, 5:27 AM
dos added inline comments.Jan 24 2018, 12:00 PM
globalaccel.cpp
59

I've just tested it (with 5.11.95) and it does work on Wayland.

graesslin accepted this revision.Jan 24 2018, 4:36 PM
graesslin added inline comments.
globalaccel.cpp
59

In that case: sorry for the noise.

This revision is now accepted and ready to land.Jan 24 2018, 4:36 PM
dos marked 3 inline comments as done.Jan 29 2018, 11:29 PM
Closed by commit R133:e861e10d84c8: Add touchpad shortcuts to the whitelist (authored by dos, committed by davidedmundson). · Explain WhyJan 29 2018, 11:41 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mglobalaccel.cpp (3 lines)

Diff 26199

View Options

globalaccel.cpp

Loading...