for ulong definition
ClosedPublic
Actions

Authored by conet on Jan 23 2018, 3:01 PM.

Details

Reviewers

tbaumgart
wojnilowicz

Summary

On macOS <sys/types.h> does not contain a typedef for ulong.

Test Plan

Built on macOS.

Diff Detail

Repository

R261 KMyMoney

Lint

Lint Skipped

Unit

Unit Tests Skipped

conet requested review of this revision.Jan 23 2018, 3:01 PM

conet created this revision.

What about the entry in kmymoney/misc/platformtools.h ? I changed it here as well and it compiled fine. Can you add that one as well?

wojnilowicz accepted this revision.Jan 23 2018, 5:26 PM

This revision is now accepted and ready to land.Jan 23 2018, 5:26 PM

I was planning to replace also that definition but somehow thought that I can't because it does not depend on QtCore, I see now that I was wrong, going to update the patch.

Please review the new diff. I removed all traces of <sys/types.h> and removed the defined from config-kmymoney.h.cmake which were not used anymore.

Where should I push this? To master and cherry pick in 5.x or to 5.x and merge into master?

Land it onto the 5.0 branch. No need for an instant merge. I plan to do that later this week (together with all the other fixes we have so far).

Pushed as https://commits.kde.org/kmymoney/207a463a14bbc0fd7d7cf7111fec2ea1f8d1826d sorry, I missed the 'Differential Revision' keyword.

Revision Contents
Changeset List

			Path	Packages
M			CMakeLists.txt (1 line)
M			config-kmymoney.h.cmake (6 lines)
M			kmymoney/dialogs/kselectdatabasedlg.cpp (2 lines)
M			kmymoney/misc/platformtools.h (3 lines)
M			kmymoney/mymoney/storage/imymoneyserialize.h (4 lines)
M			kmymoney/mymoney/storage/imymoneystorage.h (4 lines)