Differential D10051

Fix sorting bug
ClosedPublic
Actions

Authored by mikkoh on Jan 23 2018, 2:27 PM.

Details

Reviewers
elvisangelaccio
Group Reviewers
Kronometer
Commits
R136:f1a028e2d314: Fix sorting bug
Summary

laps over 9 got wrongly sorted

numbers should not get converted to strings before sorting

Diff Detail

Repository
R136 Kronometer
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
mikkoh requested review of this revision.Jan 23 2018, 2:27 PM
mikkoh created this revision.
elvisangelaccio accepted this revision.Jan 24 2018, 9:50 PM

Thanks for the patch!
What's the email address you want to use for the commit message?

This revision is now accepted and ready to land.Jan 24 2018, 9:50 PM
mikkoh added a comment.Jan 25 2018, 2:47 AM

address is: mihepeau@suomi24.fi

Was too difficult to get it compiled from source in Ubuntu kde 17.10 and I gave
up. In Opensuse tumbleweed it worked as easily as is possible.

It seems to me that this could have less dependencies. Qt version could also be
less than 5.9, because it is such a simple program.

Also, sending that patch was really hard and confusing on kde side (not on
github). I thought that I could copy paste what QtCreator gave.

elvisangelaccio added a comment.Jan 27 2018, 4:48 PM
In D10051#195818, @mikkoh wrote:

address is: mihepeau@suomi24.fi

Was too difficult to get it compiled from source in Ubuntu kde 17.10 and I gave
up. In Opensuse tumbleweed it worked as easily as is possible.

It seems to me that this could have less dependencies. Qt version could also be
less than 5.9, because it is such a simple program.

Also, sending that patch was really hard and confusing on kde side (not on
github). I thought that I could copy paste what QtCreator gave.

Yeah, we are aware of those issues. You may want to subscribe to https://phabricator.kde.org/T7116 where we are tracking them :)

Closed by commit R136:f1a028e2d314: Fix sorting bug (authored by mikkoh, committed by elvisangelaccio). · Explain WhyJan 27 2018, 5:16 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/models/lapmodel.cpp (2 lines)

Diff 26076

View Options

src/models/lapmodel.cpp

Loading...