User Details
- User Since
- Aug 17 2017, 2:42 PM (352 w, 2 d)
- Availability
- Available
Jan 3 2022
Dec 23 2020
Dec 21 2020
Feb 18 2020
Dec 30 2019
Dec 29 2019
LGTM
Dec 28 2019
Feb 24 2019
Fix grammar mistake
Feb 12 2019
May I ask for an another round of review (and if looks good merge?)
Thanks in advance for your time!
Aug 16 2018
Thanks for the review, I have changed the raw char literals to QChar-s.
Fix review comment.
Jul 23 2018
Updated revision to 8 from 7 as suggested in the review.
Jul 22 2018
Any news on the reviewing of this one guys?
Feb 16 2018
Feb 15 2018
Oct 12 2017
Oct 2 2017
Many thanks for the reviews, I have fixed them.
Oct 1 2017
@elvisangelaccio
After several trials I consider the "set unmounted directory to home" out of scope of this patch because I have not found any method which could reliably set the tabs with unmounted paths to home in time.
At the moment I can only think about some QTimer based hack, but I would not like to include it to this patch.
Sep 29 2017
@elvisangelaccio
I have implemented the "storage teardown requested -> set the opened tabs to home if mounting path is open" method, but this approach cannot close the terminal in time when the teardown request came externally. (Umount requested from the indicator applet for e.g.). The tabs are set to the home directory properly both the terminal, but the unmount manager says that the mountpath is opened in an application.
I would rather merge the two approaches: asking the terminal to cd to home first and then loop over the tabs and set them to home if mountpath is opened.
Sep 17 2017
Sep 16 2017
Sep 10 2017
Sep 5 2017
Aug 21 2017
Aug 17 2017
Okay so:
- License updated to MIT
- Added detection for invalid RecordType (05<)
- Changed formatting to use builtin formats
- Added autotest case with a sample file with two malformed lines and a HTML output
- I think folding tests are not acceptible for this file type.
Sure, I have just seen that these xmls could be autotested.