I have created an syntax highlight file for the Kate.
The coloring scheme tries to match the coloring use by the VIM. Unfortunately the Kate syntax highlight does not support changing the background color, so in some cases the VIM scheme was modified to make it better looking.
For more information about the Intel HEX files please see:
https://en.wikipedia.org/wiki/Intel_HEX
Ps.: I have filed a KDE bug 383610 about this patch.
Open an Intel HEX file with syntax highlight installed.
| Automatic diff as part of commit; lint not applicable. |
| Automatic diff as part of commit; unit tests not applicable. |
Cool, I use them at work ;=)
Could you add a minimal example as unit test?
And could we have as license something like "MIT"?
For the coloring: it is preferred to use some of our default styles and no hard coded colors to make color schemes possible.
Please change the kateversion, and as Christoph mentioned please remove hard-coded colors. You can find a list of all valid default styles here: https://kate-editor.org/2014/03/07/kate-part-kf5-new-default-styles-for-better-color-schemes/
| data/syntax/hex.xml | ||
|---|---|---|
| 3 ↗ | (On Diff #18291) | kateversion 16.04 is not a valid number. Please change to kateversion="5.0" |
Sure, I have just seen that these xmls could be autotested.
And could we have as license something like "MIT"?
Sure, I have no objections about it.
For the coloring: it is preferred to use some of our default styles and no hard coded colors to make color schemes possible.
Thanks for the tips, I will change the license, colors and add autotest.
Okay so:
I am happy beside one thing I missed: I think the file should be called intelhex.xml, given its for the intel hex format only (the name is already fine, did miss that the filename is only hex).
Otherwise: very nice, thanks again for the contribution.
I agree with the renaming, uploaded a new diff with the proper filename. I am not really familiar with the Phabricator (yet), do I need to do anything else?
Hmm, the diff still looks like it has the old names, perhaps the update went wrong somehow?
Yepp, I have missed the second page after the diff upload. It should be correct now.
syntax-highlighting.git, on first glance not landed atm.
Can you commit on your own or should I push it for you Miklos?
Hi Cullmann,
I am on holiday ATM so if you could push it that would be awesome. Otherwise I can take care of it next week.
Thanks in advance!
Damnit, i commited it and now the tests are not passing :( https://build.kde.org/job/Frameworks%20syntax-highlighting%20kf5-qt5%20FreeBSDQt5.7/89/console
Should be fixed now:
commit fd79b6842c6f33a1aca4f500354ca2a69c52689e
Author: Christoph Cullmann <cullmann@kde.org>
Date: Wed Sep 6 08:08:49 2017 +0200
add missing reference files for tests, looks ok, I think Differential Revision: https://phabricator.kde.org/D7367