@aacid fixed this
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Feb 5 2022
Aug 22 2021
I haven't used scripting plugin myself and I doubt that many people use it. So I think it's fine to remove it. And if somebody really needs it, patches are welcome.
Oct 26 2020
Change pushed: https://websvn.kde.org/?view=revision&revision=1583594
Oct 25 2020
Address review comments.
In D29878#676647, @aacid wrote:Shouldn't the
if entry.msgid == msgid:
now also have some kind of msgctxt checking?
Get rid of find_tags function since it introduces scoping problems (main program body in this file is not scoped)
Jun 25 2020
In D29852#675658, @trufanov wrote:Commited: https://invent.kde.org/network/libktorrent/-/commit/5b0abf8378d497c5a8881771518df6a02404d031
Could you please clarify a process? Shall I pass the review on phabricator then create a pull request on Invent? Or just create a Pull Request on Invent?
In D29864#675651, @trufanov wrote:Hmm... I forget to fix indentation.
It's quite annoying that KTorrent and Libktorrent projects both have different styles of indentation: tabs and spaces.The changes were commited with: https://invent.kde.org/network/libktorrent/-/commit/8fc90833f2747adcee209cef29f626dd034022ac
Jun 24 2020
Other than whitespace issue it seems fine.
Jun 20 2020
Looks good. It's good that there are some new tests to check validity of those arithmetic operations!
Jun 16 2020
Jun 14 2020
Yeah, looking at the code I think you are right.
Jun 6 2020
Jun 5 2020
OK, the patch looks fine. I would suggest pushing it.
I can try to look at it this weekend, but maybe open it on invent.kde.org
Jun 4 2020
Is there any reason why this is abandonned? It seems to work fine on my system.
Jun 3 2020
Looks fine. Although, personally I would rather require Qt 5.9 instead of copying implementation. Qt 5.9 is not exactly new.
May 28 2020
May 15 2020
May 8 2020
Mar 28 2020
Mar 22 2020
Mar 21 2020
Mar 15 2020
Feb 8 2020
Hmm, it looks like it breaks ABI, so we should have bumped kpmcore SOVERSION in this commit. I'll do that now.
In D21261#608154, @shubham wrote:@stikonas I am a bit confused, can you please help a bit?
Feb 6 2020
Feb 1 2020
Jan 25 2020
Jan 20 2020
Sorry for typos, What I meant was:
Jan 17 2020
In D21261#595885, @shubham wrote:@stikonas Ping?
Jan 12 2020
Jan 10 2020
In D21903#591199, @arnaudr wrote:Hello here! Is there anything blocking this RFC? Reading the backlog, it seems that everything was good, but that was 6 months ago. Is there anything I can do to help this RFC move forward? Thanks!
Jan 9 2020
Jan 1 2020
In T12165#216097, @dfaure wrote:Do you think it could use polkit? Or is this about an embedded root terminal or something?
There is also Cervisia that uses KDESu::PtyProcess.
Dec 28 2019
Dec 27 2019
Do we still expect to have any users of kdesu? Most apps were probably ported to polkit already.
In T12429#215252, @vkrause wrote:It might make sense to collect all those iso-codes or CLDR consuming functions in e.g. KI18n and share them there? Whether that's then implemented by runtime reading iso-codes data, or compiling in the subset we need is secondary IMHO. KContacts is also only a rather accidental place for this I think.
Dec 26 2019
Dec 8 2019
Dec 7 2019
Dec 5 2019
By the way, can you upload patches for review with more context next time. E.g. something like git show -U999
Dec 2 2019
Nov 25 2019
Nov 21 2019
I'll take a better look later.
Nov 18 2019
Nov 15 2019
Nov 12 2019
Nov 10 2019
Yes, I agree, the new error is better.
Nov 7 2019
Nov 5 2019
Do you have commit rights or do I need to push it for you?
Nov 3 2019
Nov 2 2019
In D13045#557967, @trufanov wrote:I've just tried this with version 5.1.2. The app has crashed. So problem is still exists. Perhaps would be better to apply this patch?