Torrent wasn't removed from queuemanager properly. Thus calling the data(..) function caused ktorrent to crash.
Details
- Have one completed torrent in ktorrent
- Remove this torrent
- Ktorrent doesnot crash anymore
Diff Detail
- Repository
- R473 KTorrent
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Once I faced with this bug on Kubuntu 19.10 but couldn't reproduce. And I still can't reproduce it. Anyway change looks fine for me. Let's rely on stikonas opinion
ktorrent/tools/queuemanagermodel.cpp | ||
---|---|---|
152 | I'm getting
while git apply the diff bcs of this line. Could you fix? |
ktorrent/tools/queuemanagermodel.cpp | ||
---|---|---|
142 | I am a bit reluctant to use foreach in new code. On the other hand it's very similar code to the code in other parts of this file... Other than that, it looks alright. |
ktorrent/tools/queuemanagermodel.cpp | ||
---|---|---|
142 | This might result in undefined behaviour. You are iterating over a container that is being modified. You need to take a copy here |