Differential D25718

Don't display standard groups in Open torrent dialog
ClosedPublic
Actions

Authored by trufanov on Dec 3 2019, 5:53 PM.

Details

Reviewers
stikonas
Commits
R473:8e0145d6eced: Don't display standard groups in Open torrent dialog
Summary

This seems to be a mistake and is inconsistency with ::loadGroups() in pastedialog.cpp and torrentcreatordlg.cpp

The standard groups (Active uploads, Active downloads etc.) are formed automatically and choosing them in fileselectdlg.cpp gives nothing except a warning message like
"RTTI symbol not found for class 'kt::FunctionGroup<&(bool kt::member<&kt::not_running, &kt::download>(bt::TorrentInterface*))>'"
in stderr.

This patch hides them from the list of available groups. Only "All Torrents" (default, hardcoded) and groups with CUSTOM_GROUP flag (if any) shall be displayed.

Test Plan

Open any *.torrent file.
Try to choose any non custom group. Press Ok.
The torrent still be in "Ungrouped torrents"

Diff Detail

Repository
R473 KTorrent
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trufanov requested review of this revision.Dec 3 2019, 5:53 PM
trufanov created this revision.
stikonas accepted this revision.Dec 5 2019, 12:05 AM

By the way, can you upload patches for review with more context next time. E.g. something like git show -U999

This revision is now accepted and ready to land.Dec 5 2019, 12:05 AM
Closed by commit R473:8e0145d6eced: Don't display standard groups in Open torrent dialog (authored by trufanov). · Explain WhyDec 5 2019, 11:13 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Mktorrent/dialogs/fileselectdlg.cpp (2 lines)

Diff 70946

View Options

ktorrent/dialogs/fileselectdlg.cpp

Loading...