In T14763#261293, @ahmadsamir wrote:In T14763#261292, @alex wrote:If systemsettings5 is the executable, but datafiles get installed in a systemsettings folder it will not make a difference if the executable is versioned or not.
See https://invent.kde.org/plasma/systemsettings/-/blob/master/app/CMakeLists.txt#L37.Good point; I don't know how they handle that.
- Queries
- All Stories
- Search
- Advanced Search
Feed Advanced Search
Advanced Search
Advanced Search
Aug 15 2023
Aug 15 2023
Oct 5 2021
Oct 5 2021
krop added a comment to T14763: Remove the "5" suffix from KF binary names, and provide compat symlinks in KF5.
Apr 6 2021
Apr 6 2021
In T14233#253117, @dfaure wrote:IOW this is solution 3: offer both KF5/Qt5 and KF6/Qt6 modules in ECM, all we need to port the apps is append a number.
Mar 15 2021
Mar 15 2021
krop renamed T14162: QtQuick support in Sonnet from QtQuick supports in Sonnect to QtQuick supports in Sonnet.
Dec 12 2020
Dec 12 2020
krop updated the task description for T13505: [Legal] Relicense GPL-2.0-only and LGPL-2.0-only files.
Sep 12 2020
Sep 12 2020
krop updated the task description for T13505: [Legal] Relicense GPL-2.0-only and LGPL-2.0-only files.
krop moved T13505: [Legal] Relicense GPL-2.0-only and LGPL-2.0-only files from Backlog to In Progress on the KDE PIM board.
Sep 9 2020
Sep 9 2020
krop updated the task description for T13505: [Legal] Relicense GPL-2.0-only and LGPL-2.0-only files.
Sep 8 2020
Sep 8 2020
krop updated the task description for T13505: [Legal] Relicense GPL-2.0-only and LGPL-2.0-only files.
Sep 7 2020
Sep 7 2020
krop updated the task description for T13505: [Legal] Relicense GPL-2.0-only and LGPL-2.0-only files.
Aug 19 2020
Aug 19 2020
krop updated the task description for T13505: [Legal] Relicense GPL-2.0-only and LGPL-2.0-only files.
Aug 15 2020
Aug 15 2020
For PIM repositories, I removed the COPYING.DOC files and replaced them with GFDL-1.2-or-later.txt from https://github.com/spdx/license-list-data/tree/master/text.
Aug 14 2020
Aug 14 2020
krop updated the task description for T13505: [Legal] Relicense GPL-2.0-only and LGPL-2.0-only files.
krop updated the task description for T13505: [Legal] Relicense GPL-2.0-only and LGPL-2.0-only files.
Aug 12 2020
Aug 12 2020
In T12730#237282, @cordlandwehr wrote:Thirdly, Gitlab suggests to add a file called LICENSE at the main root (which we can fully ignore, if we want).
Aug 11 2020
Aug 11 2020
I suggest removing kdelibs4support from the list. (converting the other portingaids repositories is probably not needed either)
Jun 23 2020
Jun 23 2020
Can you create an invent MR? I'll look later
Jun 4 2020
Jun 4 2020
Fix build with Qt 5.15
May 12 2020
May 12 2020
Add categories to kaddressbook-view.desktop
May 8 2020
May 8 2020
tested successfully with the openSUSE package which uses absolute paths
May 6 2020
May 6 2020
If everything is sorted and both of you agree, please accept one of the reviews and we'll happily push it if necessary.
May 3 2020
May 3 2020
D29223 addresses the issue and needs review
Apr 27 2020
Apr 27 2020
I suppose you rename the file for a good reason. Are there different "official" languages for Taiwan?
Apr 22 2020
Apr 22 2020
Apr 20 2020
Apr 20 2020
Merge branch 'release/20.04'
Don't install files twice.
Apr 18 2020
Apr 18 2020
Nicaragua Holidays
Taiwanese holidays
Mar 28 2020
Mar 28 2020
Mar 23 2020
Mar 23 2020
Mar 22 2020
Mar 22 2020
Mar 21 2020
Mar 21 2020
LGTM
In D27245#619834, @cordlandwehr wrote:So, how to move forward with this change? The two open discussion points are:
- How to handle COPYING files? --> IMO this is a general question that I want to address in a global change when we updated all the license headers. For this I created a task to track this question: https://phabricator.kde.org/T12730
LGTM
LGTM
LGTM
Mar 18 2020
Mar 18 2020
krop committed R320:3a83ddd06829: Merge remote-tracking branch 'origin/release/20.04' (authored by krop).
Merge remote-tracking branch 'origin/release/20.04'
Mar 17 2020
Mar 17 2020
Closing again. Thanks for fixing.
Mar 11 2020
Mar 11 2020
Mar 4 2020
Mar 4 2020
Feb 28 2020
Feb 28 2020
In D10041#619075, @ngraham wrote:This causes a build failure for me:
/home/nate/kde/src/kwin/plugins/platforms/drm/edid.cpp:149:19: error: expected primary-expression before ‘enum’ 149 | QFile pnpFile(QStringLiteral(HWDATA_PNPIDS_FILE)); | ^~~~~~~~~~~~~~
Feb 24 2020
Feb 24 2020
Feb 15 2020
Feb 15 2020
Feb 13 2020
Feb 13 2020
some headers have 3 leading whitespaces, some 4. Can you clarify?
Please push after fixing the remaining issues
Feb 10 2020
Feb 10 2020
LGTM
Just one thing left to fix before pushing
Feb 8 2020
Feb 8 2020
LGTM once the license file is fixed
Feb 6 2020
Feb 6 2020
same remark as for D27106. Check if FileContributor is more appropriate.
Feb 5 2020
Feb 5 2020
+1 LGTM
Feb 3 2020
Feb 3 2020
Feb 1 2020
Feb 1 2020
+1 LGTM
krop committed R477:45a87de50895: Merge remote-tracking branch 'origin/release/19.12' (authored by krop).
Merge remote-tracking branch 'origin/release/19.12'
Handle 410 Gone errors during Calendar sync
Jan 31 2020
Jan 31 2020
Jan 27 2020
Jan 27 2020
In D26931#601508, @cgiboudeaux wrote:In D26931#601505, @cordlandwehr wrote:Convert to SPDX-FileCopyrightText tags
some files have <year> by <author>, can I suggest removing this "by"?
In D26931#601505, @cordlandwehr wrote:Convert to SPDX-FileCopyrightText tags
Jan 26 2020
Jan 26 2020
LGTM
Jan 22 2020
Jan 22 2020
If you need to add KF5::SyntaxHighlighting, that means it's not supposed to be a PRIVATE link target, what KF5LibKSieveConfig.cmake.in confirms.
Jan 20 2020
Jan 20 2020
krop added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.
In D26752#597149, @patrickelectric wrote:Hi @cgiboudeaux and @bcooksley, there is a reason of why this patch is valid. Have you read the commit message ?
In Kirogi we provide a valid icon (svg) with a valid prefix (sc), as you probably know *sc* stands for for scalable (SVG) files.
Jan 19 2020
Jan 19 2020
krop added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.
In D26752#596949, @tcanabrava wrote:
krop added a comment to D26752: ECMAddAppIcon: Do not warn about mac and window icons if isnt a OS specific build.
In D26752#596809, @tcanabrava wrote:That’s not a developer issue, it’s a packaging issue.
+1 after updating the review title