COPYING
485 ↗	(On Diff #74869)	The license shall not be altered :)
LICENSES/LicenseRef-KDE-Accepted-LGPL.txt
13	missing new line.
src/comment.h
4–8	I understand something different: the copyright holder is "Intel corporation", Mateu Batle Sastre is a file contributor. See the FileContributor property: https://spdx.org/rdf/terms/dataproperties/fileContributor___-1635717172.html

krop mentioned this in D27103: KItemModels: Convert license headers to SPDX markers.Feb 6 2020, 9:28 PM

cordlandwehr mentioned this in T11550: Add SPDX License markers.Feb 8 2020, 8:46 AM

Can you add the repository name in the title of the review request? Otherwise they all look the same in emails.

cordlandwehr retitled this revision from Convert license statements to SPDX markers to Attica: Convert license statements to SPDX markers.Feb 8 2020, 10:19 AM

		Path
A	M	LICENSES/LGPL-2.0-or-later.txt (446 lines)
A	M	LICENSES/LGPL-2.1-only.txt (467 lines)
A	M	LICENSES/LGPL-3.0-only.txt (163 lines)
A	M	LICENSES/LicenseRef-KDE-Accepted-LGPL.txt (12 lines)
M		autotests/configtest.cpp (19 lines)
M		autotests/persontest.cpp (19 lines)
M		autotests/privatedatatest.cpp (19 lines)
M		autotests/providertest.cpp (19 lines)
M		src/accountbalance.h (20 lines)
M		src/accountbalance.cpp (18 lines)
M		src/accountbalanceparser.h (19 lines)
M		src/accountbalanceparser.cpp (19 lines)
M		src/achievement.h (20 lines)
M		src/achievement.cpp (19 lines)
M		src/achievementparser.h (19 lines)
M		src/achievementparser.cpp (19 lines)
M		src/activity.h (19 lines)
M		src/activity.cpp (19 lines)
M		src/activityparser.h (19 lines)
M		src/activityparser.cpp (19 lines)
M		src/atticabasejob.h (19 lines)
M		src/atticabasejob.cpp (19 lines)
M		src/atticautils.h (22 lines)
M		src/atticautils.cpp (20 lines)
M		src/buildservice.h (19 lines)
M		src/buildservice.cpp (19 lines)
M		src/buildservicejob.h (19 lines)
M		src/buildservicejob.cpp (19 lines)
M		src/buildservicejoboutput.h (19 lines)
M		src/buildservicejoboutput.cpp (19 lines)
M		src/buildservicejoboutputparser.h (19 lines)
M		src/buildservicejoboutputparser.cpp (19 lines)
M		src/buildservicejobparser.h (19 lines)
M		src/buildservicejobparser.cpp (19 lines)
M		src/buildserviceparser.h (19 lines)
M		src/buildserviceparser.cpp (19 lines)
M		src/category.h (19 lines)
M		src/category.cpp (19 lines)
M		src/categoryparser.h (19 lines)
M		src/categoryparser.cpp (19 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	74869	520b90e		Feb 2 2020, 5:49 PM	★	★
Diff 2	75579	520b90e	Solve review findings	Feb 13 2020, 8:10 AM	★	★
Diff 3	75586	18cd11b	R235:4db348a7bb1cd7d3b6afda395989aaf365ee9035	Feb 13 2020, 10:31 AM	★	★

Commit	Tree	Parents	Author	Summary	Date
066af548c3cc	cde0e7ff8a03	8ee84ba3ebae	Andreas Cord-Landwehr	Use FileContributor tag for Author statements without copyright claim	Feb 13 2020, 8:02 AM
8ee84ba3ebae	ab8460cbc0fb	b94ab0c1b873	Andreas Cord-Landwehr	Fix license files	Feb 13 2020, 7:54 AM
b94ab0c1b873	2df08568c583	88f4ef287075	Andreas Cord-Landwehr	Convert license statements to SPDX markers (Show More…)	Feb 2 2020, 5:46 PM
88f4ef287075	05d43a728190	520b90e96ab7	Andreas Cord-Landwehr	Convert license statements to SPDX markers	Feb 2 2020, 5:44 PM

Attica: Convert license statements to SPDX markersClosedPublicActions

Details

Diff Detail

Large Diff

Revision ContentsChangeset List

Diff 75586

LICENSES/LGPL-2.0-or-later.txt

LICENSES/LGPL-2.1-only.txt

LICENSES/LGPL-3.0-only.txt

LICENSES/LicenseRef-KDE-Accepted-LGPL.txt

autotests/configtest.cpp

autotests/persontest.cpp

autotests/privatedatatest.cpp

autotests/providertest.cpp

src/accountbalance.h

src/accountbalance.cpp

src/accountbalanceparser.h

src/accountbalanceparser.cpp

src/achievement.h

src/achievement.cpp

src/achievementparser.h

src/achievementparser.cpp

src/activity.h

src/activity.cpp

src/activityparser.h

src/activityparser.cpp

src/atticabasejob.h

src/atticabasejob.cpp

src/atticautils.h

src/atticautils.cpp

src/buildservice.h

src/buildservice.cpp

src/buildservicejob.h

src/buildservicejob.cpp

src/buildservicejoboutput.h

src/buildservicejoboutput.cpp

src/buildservicejoboutputparser.h

src/buildservicejoboutputparser.cpp

src/buildservicejobparser.h

src/buildservicejobparser.cpp

src/buildserviceparser.h

src/buildserviceparser.cpp

src/category.h

src/category.cpp

src/categoryparser.h

src/categoryparser.cpp

src/cloud.h

src/cloud.cpp

src/cloudparser.h

src/cloudparser.cpp

src/comment.h

src/comment.cpp

src/commentparser.h

src/commentparser.cpp

src/config.h

src/config.cpp

src/configparser.h

src/configparser.cpp

src/content.h

src/content.cpp

src/contentparser.h

src/contentparser.cpp

src/deletejob.h

src/deletejob.cpp

src/distribution.h

src/distribution.cpp

src/distributionparser.h

src/distributionparser.cpp

src/downloaddescription.h

src/downloaddescription.cpp

src/downloaditem.h

src/downloaditem.cpp

src/downloaditemparser.h

src/downloaditemparser.cpp

src/event.h

src/event.cpp

src/eventparser.h

src/eventparser.cpp

src/folder.h

src/folder.cpp

Attica: Convert license statements to SPDX markers
ClosedPublic
Actions

Revision Contents
Changeset List