Decouple KBookmarksMenu from KActionCollection

Authored by nicolasfella on Mar 24 2020, 8:10 PM.

Description

Decouple KBookmarksMenu from KActionCollection

Summary: The usage of KActionCollection makes KBookmarks depend on KXMLGui. To allow to get rid of this rather heavy dependency for KF6 a new constructor is introduced that does not take a KActionCollection. Instead apps that use KBookmarksMenu and KXMLGui are encouraged to manually add the relevant actions to their action collection. It's not pretty, but better than depending on KXMLGui, especially given that KIO depends on KBookmarks and thus on KXMLGui.

Test Plan: Tested with patched Dolphin (new constructor is used) and unpatched Konsole.

Reviewers: Frameworks, dfaure

Reviewed By: dfaure

Subscribers: kossebau, dfaure, apol, kde-frameworks-devel

Tags: Frameworks

Maniphest Tasks: T12056

Differential Revision: https://phabricator.kde.org/D25660

Details

Committed
nicolasfellaMar 24 2020, 8:10 PM
Reviewer
dfaure
Differential Revision
D25660: Decouple KBookmarksMenu from KActionCollection
Parents
R294:5caaa3589b25: GIT_SILENT Upgrade KF5 version to 5.69.0.
Branches
Unknown
Tags
Unknown