Diffusion Krusader 94ea5b69af14

Refactored and unified icon rendering, implemented per-icon fallback logic
94ea5b69af14
Actions

Authored by nmel on Apr 22 2018, 10:00 PM.

Description

Refactored and unified icon rendering, implemented per-icon fallback logic

Merge branch 'fix-missing-icons'

The merged branch contains implementation of per-icon fallback logic:

Search icon in the active icon theme — if found, use it.
Search it in the icon theme that is specified in Krusader config — if found, use it.
Search it in Breeze or Oxygen (in case any of these installed) — if found, use it.
Otherwise use a default "icon-missing" icon bundled with Krusader.

FIXED: [ 372964 ] At least one Oxygen icon in Krusader is not correctly seen (using Kubuntu 16.04)
BUG: 372964

FIXED: [ 372966 ] Some icons are not seen using a plain Ubuntu (not Kubuntu) 16.04
BUG: 372966

CCBUG: 376699
CCBUG: 381676
CCBUG: 386554
CCBUG: 388691
CCBUG: 391899

Differential Revision: https://phabricator.kde.org/D10352

Details

Committed

nmel	Apr 22 2018, 10:00 PM

Differential Revision

D10352: Fix insufficient icon theme issues

Parents

R167:1d9988330eac: Update the docs according to keybinding changes
R167:95a0ba17cc2f: Fixed an icon variable name.

Branches

Unknown

Tags

Unknown

nmel committed R167:94ea5b69af14: Refactored and unified icon rendering, implemented per-icon fallback logic (authored by nmel).Apr 22 2018, 10:00 PM

Merged Changes

Commit		Author	Details	Committed
95a0ba17cc2f		nmel	Fixed an icon variable name.	Apr 21 2018
36ec531a0dac		nmel	Added text fallback to some Synchronizer buttons	Apr 21 2018
3387a181317c		nmel	Icon: improved a method name and a comment	Apr 18 2018
0a89152c8260		nmel	Added workaround for Breeze variant selection based on theme lightness	Apr 18 2018
753d508d270c		nmel	Replaced KIconLoader::loadMimeTypeIcon with Icon	Apr 18 2018
508675633016		nmel	Added dynamic selection of light or dark Breeze fallback theme	Apr 18 2018
86115e3b688d		nmel	Updated icon-missing icon to be similar in style to the Breeze icon theme	Apr 18 2018
297338f6de21		nmel	Fixed missing icons in the file list (KrView)	Apr 18 2018
4864e38a23be	D10352	nmel	Fixed names of variables, functions, members, methods related to icons	Apr 14 2018
85de0cec2734	D10352	nmel	Icon: Added overlay support and replaced KDE::icon in the project	Apr 14 2018
8612eddd542e	D10352	nmel	Fixed icon for dragging multiple items between panels	Apr 13 2018
e90ea0ec104d	D10352	nmel	Icon: don't apply fallback in case of empty icon name	Apr 13 2018
5d64608bc6a8	D10352	nmel	Removed KrGlobal::iconLoader and cleaned up KIconLoader includes	Apr 13 2018
0ccf0748e534	D10352	nmel	Icon: improved comments and messages	Apr 13 2018
9da2a28d6dd8	D10352	nmel	Used KIconLoader in icon search to improve mime icons	Apr 13 2018
44d37ecbada1	D10352	nmel	Replaced SmallIcon with Icon	Apr 13 2018
0b4df738799f	D10352	nmel	Replaced FL_LOADICON with FileListIcon::pixmap	Apr 13 2018
9b5d31904fde	D10352	nmel	Fixed misuse of FL_LOADICON	Apr 13 2018
02100ceabaa2	D10352	nmel	Switched from KIconLoader to Icon in ActionMan	Apr 13 2018
c741229623c1	D10352	nmel	Switched krLoader->loadIcon to Icon in case it's used as QPixmap	Apr 13 2018
575f3e00a54d	D10352	nmel	Switched krLoader->loadIcon to Icon in case it's used as QIcon	Apr 13 2018
b475b1ac15f0	D10352	nmel	Fixed icons on Synchronizer buttons	Apr 13 2018
5f5f7477a603	D10352	nmel	Replaced QIcon::hasThemeIcon calls with Icon::exists; refactored icon search	Apr 13 2018
ab5226f0aeba	D10352	nmel	Switched app icon to Icon	Apr 11 2018
580ac5efe6b0	D10352	nmel	+ Konfigurator option to specify a fallback icon theme	Apr 11 2018
aeae6781ef02	D10352	nmel	Implemented icon cache and system theme change handling	Apr 11 2018
27d4082dcc6e	D10352	nmel	Fixed icons in User Action Examples	Apr 11 2018
e1828f60ccc8	D10352	nmel	Added loading fallback icon from resource file	Apr 11 2018
10caec54a1d1	D10352	nmel	Replaced QIcon::fromTheme with Icon instances	Apr 11 2018
218489c8cd1b	D10352	nmel	Added Icon class that implements per-icon fallback logic	Apr 11 2018
0a53a37417e2	D10352	martinkostolny/nmel	Removed old commented code for handling icons	Apr 11 2018

Changes (79)

				Path	Packages
	M			krusader/ActionMan/actionproperty.cpp
	M			krusader/ActionMan/addplaceholderpopup.cpp
	M			krusader/ActionMan/useractionlistview.cpp
	M			krusader/ActionMan/useractionpage.cpp
	M			krusader/BookMan/kraddbookmarkdlg.cpp
	M			krusader/BookMan/krbookmark.cpp
	M			krusader/BookMan/krbookmark.h
	M			krusader/BookMan/krbookmarkbutton.cpp
	M			krusader/BookMan/krbookmarkhandler.cpp
	M			krusader/CMakeLists.txt
	M			krusader/Dialogs/checksumdlg.cpp
	M			krusader/Dialogs/krspwidgets.cpp
	M			krusader/Dialogs/kurllistrequester.cpp
	M			krusader/Dialogs/newftpgui.cpp
	M			krusader/Dialogs/packguibase.cpp
	M			krusader/Dialogs/popularurls.cpp
	M			krusader/DiskUsage/diskusage.cpp
	M			krusader/DiskUsage/diskusagegui.cpp
	M			krusader/DiskUsage/dulines.cpp
	M			krusader/DiskUsage/dulistview.cpp
	M			krusader/DiskUsage/radialMap/widgetEvents.cpp
	M			krusader/FileSystem/fileitem.cpp
	M			krusader/FileSystem/fileitem.h
	M			krusader/FileSystem/krtrashhandler.cpp
	M			krusader/FileSystem/krtrashhandler.h
	M			krusader/Filter/advancedfilter.cpp
	M			krusader/Filter/generalfilter.cpp
	M			krusader/GUI/dirhistorybutton.cpp
	M			krusader/GUI/kcmdline.cpp
	M			krusader/GUI/kcmdmodebutton.cpp
	M			krusader/GUI/krremoteencodingmenu.cpp
	M			krusader/GUI/krremoteencodingmenu.h
	M			krusader/GUI/mediabutton.cpp
	M			krusader/GUI/profilemanager.cpp
	M			krusader/JobMan/jobman.cpp
	M			krusader/KViewer/krviewer.cpp
	M			krusader/KViewer/lister.cpp
	M			krusader/Konfigurator/kggeneral.cpp
	M			krusader/Konfigurator/kgprotocols.cpp
	M			krusader/Konfigurator/kgstartup.cpp
	M			krusader/Konfigurator/konfigurator.cpp
	M			krusader/Konfigurator/konfiguratoritems.cpp
	M			krusader/Konfigurator/krresulttabledialog.cpp
	M			krusader/Locate/locate.cpp
	M			krusader/MountMan/kmountman.cpp
	M			krusader/MountMan/kmountmangui.cpp
	M			krusader/Panel/PanelView/krview.cpp
	M			krusader/Panel/PanelView/krviewfactory.cpp
	M			krusader/Panel/PanelView/krviewfactory.h
	M			krusader/Panel/krfiletreeview.cpp
	M			krusader/Panel/krsearchbar.cpp
	M			krusader/Panel/listpanel.cpp
	M			krusader/Panel/listpanelactions.cpp
	M			krusader/Panel/panelcontextmenu.cpp
	M			krusader/Panel/sidebar.cpp
	M			krusader/Search/krsearchdialog.cpp
	M			krusader/Synchronizer/synchronizedialog.cpp
	M			krusader/Synchronizer/synchronizergui.cpp
	M			krusader/UserAction/kraction.cpp
	M			krusader/actionsbase.cpp
	P			krusader/filelisticon.cpp Copied from krusader/Panel/krpanel.cpp
	V			krusader/{filelisticon.h ← kicons.h}
	A			krusader/icon.cpp
	P			krusader/icon.h Copied from krusader/DiskUsage/radialMap/segmentTip.h
	A			krusader/icons/icon-missing.svgz
	D			krusader/kicons.cpp
	V			krusader/{kicons.h → filelisticon.h}
	M			krusader/kractions.cpp
	M			krusader/krglobal.cpp
	M			krusader/krglobal.h
	M			krusader/krslots.cpp
	M			krusader/krusader.cpp
	M			krusader/krusader.h
	M			krusader/krusaderview.cpp
	M			krusader/main.cpp
	M			krusader/panelmanager.cpp
	M			krusader/paneltabbar.cpp
	M			krusader/resources.qrc
	M			krusader/useraction_examples.xml