This fixes the colors of things like context menus and application menus
Details
- Reviewers
- None
- Group Reviewers
VDG Breeze - Commits
- R31:f803a89e2443: Fix colors from KStatefulBrushes not using application colorschemes
Old:
New:
Diff Detail
- Repository
- R31 Breeze
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
How likely is it for distros using Qt < 5.13 to receive an update to Breeze that isn't a backport?
As long as Breeze itself doesn't have a hard dependency on ≥ Qt 5.13, you'll need to handle that case, and make sure the added code either still works for 5.13 or gets# ifdef'd out. ...Or you could bump the dep to Qt 5.13, but that's probably not feasible given the relative recency of its release and the fact that it's distributed with Plasma, which is not bumping the Qt dep that high.
Please add the workaround for a bug fixed in qt 5.13 (eventfilter and stuff). Some people would like to compile it on current systems. In such case non-system Qt is not an option, as the style plugin won't load in older Qt. Also, the code is already written with nice ifdefs and works, so why not.
kstyle/breezestyle.cpp | ||
---|---|---|
198 | You can make it more readable like this: #if QT_VERSION < QT_VERSION_CHECK(5,13,0) |
I thought the hex values were used because it's also supposed to be possible to compile Breeze for Qt 4? I remember reading that Qt 4 needs hex numbers for some reason.
Sounds like you know more than me. Still, the top one is inside a no-KDE4 ifdef, if I'm reading the code right.
Ah, that's true. However, unless someone who knows more than me says it's OK, I think I'd like to keep the hex value with a comment to make it more readable.
Looking back at the quality of my last Breeze review, maybe @hpereiradacosta could have a go. :)
Considering the changes were already agreed upon before I made this diff, it seem safe to land without further review.