As part of the QTabBar refactoring, honouring of the new tab behaviour
setting was lost. Restore using a simpler implementation that simply
asks QTabWidget for the current index.
BUG: 396701
hindenburg | |
tcanabrava |
Konsole |
As part of the QTabBar refactoring, honouring of the new tab behaviour
setting was lost. Restore using a simpler implementation that simply
asks QTabWidget for the current index.
BUG: 396701
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
I tougth I fixed that a while ago
Em dom, 30 de set de 2018 às 04:34, Nathaniel Graham <
noreply@phabricator.kde.org> escreveu:
ngraham added reviewers: Konsole, hindenburg, tcanabrava. View Revision
https://phabricator.kde.org/D15828
*REPOSITORY*
R319 Konsole*REVISION DETAIL*
https://phabricator.kde.org/D15828*To: *roberts, Konsole, hindenburg, tcanabrava
*Cc: *konsole-devel, herrold, ngraham, maximilianocuria, hindenburg
I thought this was fixed as well but the 'New tab behavior" setting appears to be ignored.
@hindenburg, @tcanabrava: I cannot find a pending a review that would re-add this functionality. Should I push this or do you want to deal with it separately?
Push.
My time is limited unfortunately.
Next week I'll have more time for konsole but work has eating my time.
Em sáb, 6 de out de 2018 às 09:38, Lindsay Roberts <
noreply@phabricator.kde.org> escreveu:
roberts added a comment. View Revision
https://phabricator.kde.org/D15828@hindenburg https://phabricator.kde.org/p/hindenburg/, @tcanabrava
https://phabricator.kde.org/p/tcanabrava/: I cannot find a pending a
review that would re-add this functionality. Should I push this or do you
want to deal with it separately?*REPOSITORY*
R319 Konsole*REVISION DETAIL*
https://phabricator.kde.org/D15828*To: *roberts, Konsole, hindenburg, tcanabrava
*Cc: *konsole-devel, herrold, ngraham, maximilianocuria, hindenburg