Home
Phabricator
Search
Log In
Transactions
D12301
Change Details
Change Details
Old
New
Diff
{nav Browse} mode: The existing total count is now split into images and videos, e.g. "5 images, 3 videos". When 2 or more documents (that is, images or videos) are selected, the label changes to display how many are selected and their total size. E.g. "4 of 10 selected (3.4 MiB). {nav View} mode: A new label in the status bar, showing the current document index, and total in the folder, e.g. "32 of 753". This label is hidden in Lighttable mode, or if there is no room to display it. {nav Full Screen} mode: Similar to {nav View}, the current index and total count is displayed. This is in the format "32 of 753", and is anchored to the bottom right of the information panel. Each mode calculates these values independently. This is because for {nav View} and {nav Full Screen}, the thumbnail bar model has already filtered out any item that isn't viewable, therefore it's easy to simply get the current index and total items. In {nav Browse}, folders and archives are displayed, so there needs to be extra logic that filters them out appropriately. BUG: 203042 FIXED-IN: 18.08.0 Browse: {F5811297} Browse (with selection): {F5811298} View: {F5811299} View (compare): {F5811300} Full Screen: {F5814068} Full Screen (large thumbnails): {F5814069} Full Screen (thumbnail bar disabled): {F5814071}
{nav Browse} mode: The existing total count is now split into images and videos, e.g. "5 images, 3 videos". When 2 or more documents (that is, images or videos) are selected, the label changes to display how many are selected and their total size. E.g. "4 of 10 selected (3.4 MiB). {nav View} mode: A new label in the status bar, showing the current document index, and total in the folder, e.g. "32 of 753". This label is hidden in Lighttable mode, and elided if there's no room for it. {nav Full Screen} mode: Similar to {nav View}, the current index and total count is displayed. This is in the format "32 of 753", and is anchored to the bottom right of the information panel. Each mode calculates these values independently. This is because for {nav View} and {nav Full Screen}, the thumbnail bar model has already filtered out any item that isn't viewable, therefore it's easy to simply get the current index and total items. In {nav Browse}, folders and archives are displayed, so there needs to be extra logic that filters them out appropriately. BUG: 203042 FIXED-IN: 18.08.0 Browse: {F5811297} Browse (with selection): {F5811298} View: {F5811299} View (compare): {F5811300} Full Screen: {F5814068} Full Screen (large thumbnails): {F5814069} Full Screen (thumbnail bar disabled): {F5814071}
{nav Browse} mode: The existing total count is now split into images and videos, e.g. "5 images, 3 videos". When 2 or more documents (that is, images or videos) are selected, the label changes to display how many are selected and their total size. E.g. "4 of 10 selected (3.4 MiB). {nav View} mode: A new label in the status bar, showing the current document index, and total in the folder, e.g. "32 of 753". This label is hidden in Lighttable mode,
or
and elided
if there
i
'
s no room
to display it
for it
. {nav Full Screen} mode: Similar to {nav View}, the current index and total count is displayed. This is in the format "32 of 753", and is anchored to the bottom right of the information panel. Each mode calculates these values independently. This is because for {nav View} and {nav Full Screen}, the thumbnail bar model has already filtered out any item that isn't viewable, therefore it's easy to simply get the current index and total items. In {nav Browse}, folders and archives are displayed, so there needs to be extra logic that filters them out appropriately. BUG: 203042 FIXED-IN: 18.08.0 Browse: {F5811297} Browse (with selection): {F5811298} View: {F5811299} View (compare): {F5811300} Full Screen: {F5814068} Full Screen (large thumbnails): {F5814069} Full Screen (thumbnail bar disabled): {F5814071}
Continue