Thanks for checking. Closing it here.

It looks like this has landed, so closing. Please speak up if you disagree.

this is already on gitlab: https://invent.kde.org/education/marble/-/merge_requests/48/diffs

Unfortunately this did not land.
Could someone please put this on Gitlab for another review and then close it here?

Moved to https://invent.kde.org/education/kalzium/-/merge_requests/10

A few MR moving in this direction:

Looks great!

Accepted to close it, not applied

For consistency, as we already always limit the number of boys/girls to place according to the numbers in the instructions, it would be logical to do the same for the number of candies.
So, unless others disagree, I think we don't really want this behavior, and it can be changed.

I checked the code and now I can say it is intended because of line 305 in Share.qml

total: background.easyMode ? items.totalCandies : 8 * items.totalChildren + 1

In D29850#675738, @shubhammishra wrote:

Hi,

The "showCount" in datasets and "show counter" option in config behaves differently. When we disable counter from config, "totalCandies" becomes invalid and it is possible to drag unlimited candies that also means candies never become unavailable. I thought it was intended not a bug so didn't raise this before.

The "showCount" in datasets and "show counter" option in config behaves differently. When we disable counter from config, "totalCandies" becomes invalid and it is possible to drag unlimited candies that also means candies never become unavailable. I thought it was intended not a bug so didn't raise this before.

I confirm my first idea from previous comment: better keep the "show counter" as an Option, and not part of the datasets.

No problem, that's the goal of a review :).

@Supermanu Hi, Please update your diff and add the reviewers.

In D29850#675489, @jjazeix wrote:

We have 2 conflicting options for the "show counter"... If we set it on the configuration, I would expect to always have it but on some level, we have an attribute: "showCount" which overrides the configuration option. @timotheegiet, @echarruau I think it was already previously the case but it may be better to find a better wording of the option if we want to keep this behaviour?

waiting for @timotheegiet to validate the diff so we can close it. Once done, @shubhammishra please close the diff and the related tasks.

We have 2 conflicting options for the "show counter"... If we set it on the configuration, I would expect to always have it but on some level, we have an attribute: "showCount" which overrides the configuration option. @timotheegiet, @echarruau I think it was already previously the case but it may be better to find a better wording of the option if we want to keep this behaviour?

• share, added missing full stop in instructions

Played it extensively. Could not break and I find the new dataset messages much clearer.
Good for me.

Good for me. Please double check all the missing dots at the end of the sentences

• share, made dataset description shorter

Patch merged in commit 42142a0ce8b441916987f6be8463e73244ecdb93 ,
and then improved upon it in next commit 7433227a9f89d6c47ad94e515197e4d95dacaaed

@timotheegiet I have updated the difficulty levels.

updated difficulty levels

In D29853#675400, @timotheegiet wrote:

As explained in the task comments: change the number of stars for the datasets.

As explained in the task comments: change the number of stars for the datasets.

For the datasets descriptions, I think it would be more efficient to make it shorter and to the point, something like:
"Maximum n candies and n kids, no rest.", "Maximum n candies and n kids, possible rest.".... (replacing n with the actual values of course)

• updated dataset objectives