Thanks guys - this is quite likely a fix for https://bugs.kde.org/show_bug.cgi?id=367786

Thanks for investigating Ivan, and sorry for the inconvenience this has caused.

Committed: https://phabricator.kde.org/rKTEXTEDITOR025edb11ca9b0fa3685802e6c9cb608a4daa7911

UPDATE: Hopefully fix the "replay macro/ last change duplicates characters" bug - no automated test for this yet (for some reason, the tests fail for Michal, but not for me!). Michal - would you mind acting as Guinea Pig again? :)

Committed, with last commit 7acf83ca944bbec6f970d00d2f0de2f64c5a83d7

Crap - didn't realise that *every single commit* would be broadcast to the mailing list. Sorry about that!

In D1894#35403, @michalhumpula wrote:

In D1894#35400, @sstjames wrote:

In D1894#35395, @michalhumpula wrote:

Seems to be working correctly. Compiled, tested (tests and manual) on my computer with Qt5.6.1. One of the vim_keys test is failing, but at least the vi mode is back functioning, so ship it.

Thanks for testing :) Which vim_keys test is failing? They seem to all be working here, though I'm using Qt 5.5.1.

It might be just a new bug in Qt5.6 :)

>>> running command  "qa"  on text  ""
 FAIL!  : KeysTest::MacroTests() 'kate_view->viewModeHuman().contains(macroIsRecordingStatus)' returned FALSE. ()
    Loc: [/amonsul/kde/ktexteditor/autotests/src/vimode/keys.cpp(707)]
 QDEBUG : KeysTest::MarkTests()

In D1894#35395, @michalhumpula wrote:

Seems to be working correctly. Compiled, tested (tests and manual) on my computer with Qt5.6.1. One of the vim_keys test is failing, but at least the vi mode is back functioning, so ship it.

In D1892#35365, @michalhumpula wrote:

Since you have moved the code to separate folder, don't you want to move the code to separate C++ namespace too?

In D1892#34993, @dhaumann wrote:

This is a big one - essentially I think it is ok to commit. While browsing through the code, my only real comment is that instead of QRegExp, we should use QRegularExpression. However, as the patch is already big enough, I wouldn't change it now.

What is more important to note is that KDE Frameworks is released every month, see https://community.kde.org/Schedules/Frameworks.
So next tagging date is 2nd of July (bit more than two weeks). This is good, since it means that we have two weeks to fix regressions :-)

So I would be fine with committing this, and if you target the KDE Frameworks 5.24, please rather commit early than late.

More feedback and / or better reviews are of course welcome :)