In D4250#82448, @mwolff wrote:

I will need your full name and your email address to use in the git commit message.

I don't have commit rights. So if you can push that for me it would be nice.

Just a last question, with this commit when we do a :vsplit it splits the view "horizontally" (one buffer above the other") and :hsplit split the view "vertically" (one buffer on the left of the other).

use public API

Thanks to commit 00de613bcb0fb0cff587e0b8ce090b915bc6f717 no more need to setParent here.

In D4250#79740, @mwolff wrote:

That sounds... odd - the rest of the MainWindow API we overload already works, or doesn't it? I.e. what we have in ktexteditorpluginintegration.h's MainWindow only ever gets called when it is the parent() object of the MainWindow in ktexteditor.

If that is not the case, then something is really wrong. We have a test case for this in shell/tests/test_ktexteditorpluginintegration.cpp - is that failing for you?

move { to newline